Closed (won't fix)
Project:
Node Gallery
Version:
6.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Aug 2011 at 22:14 UTC
Updated:
19 Mar 2013 at 20:56 UTC
Jump to comment: Most recent file
Comments
Comment #1
jpro commentedYes, I saw it when I updated from 6.x-2.0-beta2 to 6.x-3.0. I had to revert to 6.x-2.0-beta2, due to a scheduled presentation of work in progress. I have not tried 6.x-3.0 again since.
Comment #2
scroogie commentedThis would fix it, but I'm not sure if we need to differentiate between breadcrumbs out of different sources.
Comment #3
scroogie commentedPerhaps you can test it a bit, especially with some custom page titles.
Comment #4
fugazi commented#2 confirm that it works for me. Many Thanks
Comment #4.0
fugazi commentedminor correction
Comment #5
dddave commentedComment #6
jpro commentedI tried this patch today, but it is only a partial fix. It fixes the apostrophe in breadcrumbs, but not the page(view) title.
If I click on "John Doe's Galleries" in the breadcrumbs, and look at the actual page, its page title and view title still display the apostrophe as & #039 ;
(I would be just as happy not having an apostrophe there at all, but it isn't clear to me where it is coming from)
Comment #7
acolade commentedI have the same problem.
When you try to change "argumets" properties (title and breadcrumb) on that particular view (there is "%1's Galleries" out of the box) it does nothing. The title and breadcrumb still shows "%1's Galleries" strings on the pages even if you completly delete title and breadcrumb setting in the view.
Comment #8
fugazi commentedconfirm #6
Comment #9
jpro commentedI looked into this further, and found that the apostrophe in the page titles is hard-coded into the module.
issue 1: I would prefer this were not hard-coded, I would prefer it were configurable. Apparently I'm not the only one who wasted a lot of time try to edit it by changing Views arguments.
issue 2: if it is hard-coded, it really needs to be fixed.
(This is a great gallery system, I'm sad to see it is in limbo for version 7.)
Comment #10
justintime commentedCommitted patch from scroogie in #2. jpro, #9 is a valid point, but needs a new issue for it.
Comment #11
jpro commentedThanks, justintime. My item 2 is a new item, and I do need to create a new issue for it. I'll do that.
But my item 1 is part of this issue. Page title/view title errors were a part of this original issue report, not just breadcrumbs. The patch in #2 only fixes breadcrumbs, not page titles and view titles (see #1), so this issue is only partially fixed by this patch.
Comment #12
justintime commentedOkay, gotcha. Setting to needs work.
Comment #13
jpro commentedthanks!
Comment #14
karlitos commentedAny news on this issue about the titles?
Comment #15
3olution commentedIs the problem now fixed with the latest version on git?
"Node Gallery: November 9, 2011 16:17
Commit 438341b on 6.x-3.x
by Justin Ellison
Issue #1254722 by scroogie: Apostrophes in usernames showing as '"
Or do we have still to stay with the version 6.x-2.0-beta2
Sincerely
3olution.com
Note: The latest version on git is still bugged.
Comment #16
3olution commentedWe saved the problem with the "Title Overrides" module
http://drupal.org/project/title_override
This works great for us at the moment!
We hadn't the time to look into the code it self, to find out where the bug is located.
Sincerely
3olution.com
Comment #17
zengenuity commentedIssue queue cleanup. No more changes to 6.x.
Comment #18
jackc2015 commentedIssue with the title still exists. Does anyone have a patch for it?
Comment #19
jackc2015 commentedpverrier's patch resolved the issue for me. It got rid of the ' and replaced it with an apostrophe.
The link to his patch
http://drupal.org/node/1874348#comment-6877664
Comment #19.0
jackc2015 commentedx