Thanks for making this awesome module. I'm really enjoying getting to play around with it.

One thing I noticed though is that the only way to add apps servers is in the currently enabled profile. It would be good if we could add apps servers using a hook in a module as well. Could we add that?

CommentFileSizeAuthor
#1 add_apps_server_modules-1255166-1.patch682 bytesrandallknutson

Comments

randallknutson’s picture

randallknutson commented
Status: Active » Needs review
StatusFileSize
new add_apps_server_modules-1255166-1.patch682 bytes

Here is a patch that does this.

drupalninja99’s picture

drupalninja99 commented

+1. This is okay for now, but I would think the easiest thing would be to allow you to add Apps servers via a configuration page. OpenPublic could have it's own enabled by default but allow you to add in URLs pointing to the the JS manifests for other app servers.

drupalninja99’s picture

drupalninja99 commented

Got this to kind of work but it won't show the 'install app' action for my app. Instead it shows only 'enable app' even though my manifest has all of the download information, modelled after the ideation app.

drupalninja99’s picture

drupalninja99 commented

Nm, that was an erroneous issue.

randallknutson’s picture

randallknutson commented

I agree with being able to add apps through a config page in the future. This should be in there regardless though. With it we could very easily write a module to add the config pages.

drupalninja99’s picture

drupalninja99 commented

I am guessing there isn't a way to do this without patching the apps module. So your patch could actually be used in conjunction with a settings page that dynamically populates the hook_ apps_servers_info with new servers.

randallknutson’s picture

randallknutson commented

That's correct. The only way to do this without the patch is to write it in the profile.

e2thex’s picture

e2thex commented
Status: Needs review » Fixed

@randallknutson thanks for the patch on this one.

commit 58e6035bc4b1928f4f62c076d974912ca29ff167
Date: Tue Sep 13 10:27:08 2011 -0400

Issue #1255166 by randallknutson : Allow modules to add apps servers

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.