Hi there,

I'm not sure, if this is a bug, but when you translate the "Create Preset"-string with Drupal language-manager, you are not able to create any presets anymore. The funny thing is, that when you translate "Update Preset" everything is fine...

I'd appreciate your help on this :-)

Thanx in advance

hctom

Comments

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed

It looks like "Create Preset" and "Flush Preset Images" aren't wrapped in t() functions everywhere they need to be. I've submitted the corrections to the 4.7.x, 5.x, and 5--2 branches. This fix will be included in the 1.3 version of imagecache, or you can download the development version tonight after new archives have been generated at http://drupal.org/project/imagecache.

Index: sites/all/modules/imagecache/imagecache.module
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/imagecache/imagecache.module,v
retrieving revision 1.19.2.15
diff -u -r1.19.2.15 imagecache.module
--- sites/all/modules/imagecache/imagecache.module	21 Feb 2007 22:39:22 -0000	1.19.2.15
+++ sites/all/modules/imagecache/imagecache.module	7 Mar 2007 17:11:53 -0000
@@ -356,7 +356,7 @@
     $form['presets'][$presetid]['ops']['flush'] = array(
       '#type' => 'submit',
       '#name' => 'preset-op['. $presetid .']',
-      '#value' => ('Flush Preset Images'),
+      '#value' => t('Flush Preset Images'),
     );
   }
   
@@ -375,7 +375,7 @@
   $form['presets']['new']['create'] = array(
     '#type' => 'submit',
     '#name' => 'preset-op[new]',
-    '#value' => 'Create Preset',
+    '#value' => t('Create Preset'),
     '#weight' => 10,
   );
   return $form;
hctom’s picture

hctom
Primary language German
commented

Yeah that fixed the problem... thanx for the fast reply and fix.

Cheers

hctom

hctom’s picture

hctom
Primary language German
commented
Status: Fixed » Active

I just updated to the new 5.12-version and somehow the same bug occures in the module again. I just checked the source and saw, that the appropriate t()-functions are missing again.

Can you please fix this for the future releases :-)

Thanx in advance & cheers

hctom

mr700’s picture

mr700 commented
Status: Active » Fixed

hctom, you mean in imagecache-5.x-1.2 from 2007-Feb-22, right? In imagecache-5.x-1.x-dev from 2007-Mar-15 these two are really fixed and so the next stable release will be...

hctom’s picture

hctom
Primary language German
commented

Oh sorry. I forgot to mention that, but you are right. I meant the imagecache-5.x-1.2 version. The Update Status module told me to update th emodule and I forgot I used the development version :-) So I'll look forward to the next stable release :-)

Thanx & cheers

hctom

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)