No URL rewriting in Purl for D7 [#1256272]

As far as I can tell this isn't an issue with my plugin module but I've included the code before just incase it is.

The provider callback is being called correctly on incoming urls containing the modifiers. However no outbound URLs are re-written so that the modifier is passed along.

Is there something I am doing wrong. Tried with a completely fresh install of Drupal 7.7 but no luck.


/**
 * Implements hook_purl_provider().
 */
function ai_purl_purl_provider() {
  return array(
    'ai_ministry' => array(
      'name' => t('AI Ministry'),
      'description' => t('Returns a Ministry ID from Alias.'),
      'callback' => '_ai_active_context',
      'example' => 'student',
    ),
  );
}

/**
 * Implements hook_purl_modifiers().
 */
function ai_purl_purl_modifiers() {
  return array(
    'ai_ministry' => array(
      array('value' => 'student', 'id' => 1),
      array('value' => 'youth', 'id' => 2),
    ),
  );
}

function _ai_active_context($id) {
  drupal_set_message($id);
}

Comment	File	Size	Author
#4	purl-1256272-path-prefix-d7.patch	1.44 KB	steven jones
#1	patch_commit_8ab6d7c9ed4b.patch	548 bytes	jdelaune

Comments

Comment #1

jdelaune commented 22 August 2011 at 13:40

Status:

Active

» Needs review

Status	File	Size
new	patch_commit_8ab6d7c9ed4b.patch	548 bytes

Well attached is a bug which fixes the issue, there may be a better place to solve this as I'm not sure what $global_elements initially gets set. But at least you'll know where to look.

Comment #2

dboulet commented 24 August 2011 at 21:50

The patch does seem to help, subscribing.

Comment #3

steven jones commented 6 September 2011 at 09:55

Title:	No URL rewriting going on?	» No URL rewriting in Purl for D7
Priority:	Normal	» Critical
Status:	Needs review	» Needs work

We're seeing this too.

It's down to _drupal_bootstrap_full() calling:


drupal_theme_initialize();
module_invoke_all('init');

drupal_theme_initialize() contains a call to: url() which of course runs the purl_url_outbound_alter() hook implementation.

This statically caches the elements to add to URLs as they are altered, but this has run before purl_init() so there purl hasn't parsed the URL for it yet.

When purl_init() does get called, purl sets itself up and calls the specific callbacks etc.

The patch in 1 doesn't fix the issue for us.

Comment #4

steven jones commented 6 September 2011 at 12:40

Status	File	Size
new	purl-1256272-path-prefix-d7.patch	1.44 KB

Right, so it turns out that D7 added a 'prefix' option to the url options array, which purl should be using instead of altering the actual path, this is because path aliases always take precedence over the altered path, so even after purl has altered the path, if the path has an alias, it will get changed back.

I've attached a patch that fixes up the path modifier, but the other modifiers will need fixing accordingly.

This works for me, except that Drupal core's language url re-write callbacks will wipe out the prefix if its set, which is very lame. I will raise a Drupal core issue for this.