The field group module (https://drupal.org/project/field_group) is very useful for organizing and cleaning up the display of fields on a form during form edit.

With both modules enabled, I can drag the workbench_access 'Workbench Access' field into an arbitrary field group.
When I do this, the workbench access 'Workbench Access' field dissappears from the form entirely.

It would also be very useful to perform normal 'field operations'.
What I mean is that I would like to click edit on the form field and fill out the "Help text" form so that I can provide short descript and a "see this page for section/access break-down" to the form edit field.

CommentFileSizeAuthor
#4 1256692-wa-cannot-be-regrouped.patch1.42 KBdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Unfortunately this isn't an actual field so you could/should only be able to re-order where it exists in the field UI.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Fixed

This field is already moveable in the Field UI:

Only local images are allowed.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Fixed » Active

Actually now I see what this issue is about.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 1256692-wa-cannot-be-regrouped.patch1.42 KB

This should be solved by adding $form['workbench_access']['#type'] = 'container'. I tested this with Field group enabled with vertical tab and a normal fieldset. This also cleans up the workbench_access_field_extra_fields() function since there is no workbench access element display on node render that can be re-arranged.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tested and committed #4 to Git.
http://drupalcode.org/project/workbench_access.git/commit/31ae24a

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

wrd’s picture

wrd commented

Having this exact problem in the latest release (7.x-1.2). Looks like the first change in the patch is in the current module code, but the second change (to workbench_access_form_alter()) is not. From the patch:

@@ -1375,6 +1369,7 @@ function workbench_access_form_alter(&$form, $form_state, $form_id) {
       }
     }
     workbench_access_alter_form('node_element', $element, $form_state);
+    $form['workbench_access']['#type'] = 'container';
     $form['workbench_access']['workbench_access_id'] = $element;
     $form['workbench_access']['workbench_access_scheme'] = array(
       '#type' => 'value',

From the module:

  if (empty($form['#node_edit_form'])) {
    workbench_access_alter_form($form_id, $form, $form_state);
    return;
  }

I tried adding the "container" line under the call to workbench_access_alter_form(), with no effect.

wrd’s picture

wrd commented

OK, it seems the trick is to not use the built-in form widget, and instead use a regular ol' term reference field. So nevermind!