Active Tags does not remember tags on form submit if form doesn't validate [#1257268]

If you add tags, submit the form, but the form doesn't validate for some reason (e.g. title field left empty), the entered tags disappear.

That is to say, they are still present in the hidden "field_auteurs[und][terms]" field, but don't show up in the "at-term-list" div. And what's worse: if you subsequently add new tags, the old ones get overwritten. Which kinda sucks.

Comment	File	Size	Author
#7	active_tags_widget_validate-1257268.patch	1.14 KB	attila.fekete
#1	active_tags_form_submit_validate-1257268.patch	922 bytes	synetic

Comments

Comment #1

synetic commented 27 October 2011 at 10:04

Status:

Active

» Needs review

Status	File	Size
new	active_tags_form_submit_validate-1257268.patch	922 bytes

I investigated the issue and experienced that after a form submit with validation errors the javascript and css were not included in the page html.

In the function active_tags_field_widget_form() there were 2 drupal_add_js calls and 1 drupal_add_css call. Because the form gets cached these were not run anymore on form validation errors.

I updated the code so the javascript and css files are included with the #attached form attribute. see:
http://api.drupal.org/api/drupal/developer--topics--forms_api_reference....

This patch updates the module file.

Comment #2

coakeson commented 11 December 2011 at 00:50

Your patch works great to get the javascript and css onto the validation pages.

The problem still exists where on a validation error the terms are not showing in the field_terms markup since nothing exists in the $items variable in active_tags_field_widget_form. The items are being saved in the hidden terms field and in the term_entry field if not pressing the add button, but nothing is coming through to $items. Any ideas about what could be happening?

Comment #3

boobaa

he/him

commented 24 March 2012 at 10:38

Attached is a reroll of the patch in #1. $form['#attached']['css'] is an array which may have other entries in it. Without this rerolled patch this array is simply overwritten, which is obviously wrong (think other modules adding JS and CSS stuff via the same facility). This rerolled patch is about adding active_tags' entries to this array instead of overwriting the whole array.

OTOH, the problem #2 mentions is not solved by this, either. We have even tried $form_state['rebuild'] = TRUE, without success. Another idea was messing up $_SESSION with the submitted data in a custom validate callback, reuse that here, and cleaning up the mess in a custom submit callback; but that's just another way to have PITA.