Posted by PieterDC on August 23, 2011 at 2:16pm
5 followers
| Project: | Ubercart |
| Version: | 6.x-2.x-dev |
| Component: | Shipping |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
UC Quote module already defines i18n_variables, but as the related settings form doesn't go through system_settings_form(), the i18n module has no grip on those variables. And thus, they don't get translated.
I created a patch to fix this, although I agree with TR and firewing1; it would be better to "fix" i18n, as they state in #896436: Shipping quotes and credit card information strings do not show multi-lingual description message
But for now, the patch will do, for me.
Losing formatting options for those 2 fields isn't really a loss, for me.
Enjoy!
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| ubercart-make_shipping_i18n_variables_translatable.patch | 7.31 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch ubercart-make_shipping_i18n_variables_translatable.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. | View details |
Comments
#1
The last submitted patch, ubercart-make_shipping_i18n_variables_translatable.patch, failed testing.
#2
Ps: losing formatting options is not required to fix this issue.
We can have both at the same time, cfr. uc_cart_checkout_messages_form()
Be my guest to adjust the patch...
#3
Note duplicate: #736966: Descriptive text for anonymous users in checkout page cannot be translated - Patch
#4
This patch is based on #0 but keeps the format options in place.
#5
Committed #4.
In 7.x-3.x variable translations are significantly different, so this will be fixed in #1533286: Add support for Variable module
#6
Automatically closed -- issue fixed for 2 weeks with no activity.