Hi,

I was wondering what the possibility of including a Location Email field would be... Some locations for retail buildings have direct email addresses rather than being filtered through head-office for the site I'm working on.

That would prevent me from having to use CCK Email module, and tie it in with the views I've created...

Is this difficult to do?

CommentFileSizeAuthor
#13 location-email-1257716-10.patch7.58 KBedvanleeuwen
#10 location-email-1257716-10.patch7.78 KBedvanleeuwen
#5 location_email.patch9.32 KBedvanleeuwen

Comments

Anonymous’s picture

Anonymous (not verified) commented

no action up in here?

Anonymous’s picture

Anonymous (not verified) commented

I've tried copying the phone and fax fields to turn them into an email field, but I'm not well versed enough to do that type of modification in Drupal or provide a patch.

Can someone attempt this?

I would really not like to have to add an extra CCK field or make use of another module like Addresses, which is not going to do what the locations module can do for me.

Anonymous’s picture

Anonymous (not verified) commented

can someone possibly attempt a patch for this? :-(

elgandoz’s picture

elgandoz commented
Version: 6.x-3.1 » 7.x-5.x-dev

daje!

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented
Version: 7.x-5.x-dev » 7.x-3.x-dev
Component: Miscellaneous » Code
Status: Active » Needs review
StatusFileSize
new location_email.patch9.32 KB

I have copied and changed the phone contrib, and added an entry into the location template. I have tried to create a patch to the dev version of 3 September 2012. Please test before use.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented

The patch I submitted in my previous post is not tested automatically. Have I forgotten something to trigger this?

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Active

#1931088: [META] Fixing tests tests were broken, so triggering to active

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Active » Needs review

and now its should work

Status: Needs review » Needs work

The last submitted patch, location_email.patch, failed testing.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented
StatusFileSize
new location-email-1257716-10.patch7.78 KB
edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, location-email-1257716-10.patch, failed testing.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented
Status: Needs work » Needs review
StatusFileSize
new location-email-1257716-10.patch7.58 KB
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Issue tags: +Needs tests, +Needs documentation

#13 green, nice
Good to see test coverage for this module and a few documentation strings inside README.txt for example

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Category: feature » task
Priority: Normal » Major
Status: Needs review » Needs work

#13 commited pushed to 7.x-3.x-dev
Thanks!!!

Please, fix #14 about documentation.
Thanks!

osman’s picture

osman
Location Copenhagen
commented
Issue summary: View changes
Related issues: +#2507809: Fax, Email and www fields are not exposed to Entity API
anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
commented
Assigned: Unassigned » anpolimus