See title :)

Just creating issues to be able to link them from the Roadmap.

CommentFileSizeAuthor
#12 fieldable_rerolled.patch10.32 KBberdir
#5 1258018_2.patch11.81 KBberdir
#2 1258018.patch10.22 KBberdir

Comments

BenK’s picture

Subscribing

berdir’s picture

Status: Active » Needs review
StatusFileSize
new10.22 KB

Working proof of concept.

The patch adds a default bundle, exposes manage fields/display forms through that, implements the necessary field_attach_*() functions and also contains some improvements regarding the new API, for example an __isset() magic method so that isset() and empty() work as expected.

It is possible to add new fields, create transactions with fields and display them. However, they can't be properly arranged yet, we first need to expose all existing properties as extra fields. And since most of them reside within vertical tabs, I want to research if it is possible to expose them to field_group, so that they can be moved around in any possible way.

Also, I certainly want to add some tests for this, probably port those from Privatemsg over.

Status: Needs review » Needs work

The last submitted patch, 1258018.patch, failed testing.

berdir’s picture

New patch, fixes the test fails.

Also implements hook_field_extra_fields() for the edit form. Right now, the whole vertical tabs is a single pseudo-field that you can move around but that's about it. We're currently discussing on how to extend field_group to allow us to make the different vertical_tabs visible in the UI. See #1280974: Allow to show custom in code declared elements as field_group in the UI.

berdir’s picture

StatusFileSize
new11.81 KB

Erm, and now with patch!

berdir’s picture

Status: Needs work » Needs review
berdir’s picture

#5: 1258018_2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1258018_2.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review

#5: 1258018_2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1258018_2.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review

#5: 1258018_2.patch queued for re-testing.

berdir’s picture

StatusFileSize
new10.32 KB

New patch

- Rerolled to incorporate the entity.module changes
- Removed the field group stuff, that probably has to wait. I'm in the mood of pushing this a bit along and we don't need super-fancy vertical tabs integration yet ;)
- Add simple tests to make sure that fields are displayed.

berdir’s picture

Status: Needs review » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.