Closed (fixed)
Project:
User Points
Version:
7.x-2.x-dev
Component:
Code: userpoints
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2011 at 22:55 UTC
Updated:
14 Mar 2012 at 20:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
BenK commentedSubscribing
Comment #2
berdirWorking proof of concept.
The patch adds a default bundle, exposes manage fields/display forms through that, implements the necessary field_attach_*() functions and also contains some improvements regarding the new API, for example an __isset() magic method so that isset() and empty() work as expected.
It is possible to add new fields, create transactions with fields and display them. However, they can't be properly arranged yet, we first need to expose all existing properties as extra fields. And since most of them reside within vertical tabs, I want to research if it is possible to expose them to field_group, so that they can be moved around in any possible way.
Also, I certainly want to add some tests for this, probably port those from Privatemsg over.
Comment #4
berdirNew patch, fixes the test fails.
Also implements hook_field_extra_fields() for the edit form. Right now, the whole vertical tabs is a single pseudo-field that you can move around but that's about it. We're currently discussing on how to extend field_group to allow us to make the different vertical_tabs visible in the UI. See #1280974: Allow to show custom in code declared elements as field_group in the UI.
Comment #5
berdirErm, and now with patch!
Comment #6
berdirComment #7
berdir#5: 1258018_2.patch queued for re-testing.
Comment #9
berdir#5: 1258018_2.patch queued for re-testing.
Comment #11
berdir#5: 1258018_2.patch queued for re-testing.
Comment #12
berdirNew patch
- Rerolled to incorporate the entity.module changes
- Removed the field group stuff, that probably has to wait. I'm in the mood of pushing this a bit along and we don't need super-fancy vertical tabs integration yet ;)
- Add simple tests to make sure that fields are displayed.
Comment #13
berdirCommited.