Currently the month of the credit card form defaults to January. This can lead to the default state of the credit card form to be in an invalid state should it be submitted as it stands.

I've created some sane default for this expiry month, expiry year and start year (current year - 5 of 10)

I'll attach patch following this post.

CommentFileSizeAuthor
#1 default-creditcard-expiry-month-1258254-1.patch682 bytesj0rd

Comments

j0rd’s picture

j0rd commented
StatusFileSize
new default-creditcard-expiry-month-1258254-1.patch682 bytes

Here's the patch. It's only modifying 3 lines.

j0rd’s picture

j0rd commented
Status: Active » Needs review

Update status

rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Ahh, good catch. This one's a no brainer. Committed it and realized in testing that I needed to add the nicer formatting to the start date fields that I recently added to the expiration date fields. Added it at the same time.

Thanks! (Been a little busy at the Con, but I'll be reviewing your other issues, too. : )

Commit:http://drupalcode.org/project/commerce.git/commitdiff/84d8020

j0rd’s picture

j0rd commented

No problem about the next couple days. I'd rather have you guys discussing the future, than working on the current.

Thanks for the commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.