This should improve compatibility with IE, especially older versions

CommentFileSizeAuthor
#6 recaptcha-add-once-1258910.patch1.05 KBSilicon.Valet
#4 recaptcha_1258910.patch1.34 KBliam morland
Drupal-behaviors.patch1.24 KBstovak

Comments

robloach’s picture

robloach
he/him
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Definitely :-) .

stovak’s picture

stovak commented

Clarification: My patch is for d6. For d7, the Drupal.behaviors.recapcha object needs an "attach" and "detach" method. My method needs to be moved to "attach".

e.g.

Drupal.behaviors.recapcha = {
attach: function(context) {
Recaptcha.create(Drupal.settings.recaptcha.public_key, Drupal.settings.recaptcha.container, {theme: Drupal.settings.recaptcha.theme});
},
detach: function(context) {
}
}

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs work

The patch does not apply. Please re-roll against the latest D7 dev version.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Fixed
StatusFileSize
new recaptcha_1258910.patch1.34 KB

Fixed in 94ede94. Patch as-applied attached.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
Silicon.Valet’s picture

Silicon.Valet commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new recaptcha-add-once-1258910.patch1.05 KB

Sorry to hijack the thread a bit, but since we're in here I'd like to add support for the jquery once plugin. This helped with a rather edge case usage of recaptcha and AJAX page nav but will not affect any other usages and so here you go.

Note that this is only applicable to D7 as the once plugin is not available in D6

Silicon.Valet’s picture

Silicon.Valet commented
Version: 7.x-1.x-dev » 6.x-1.x-dev

Resetting issue settings, going to create a separate issue. Please disregard previous post.

  • Liam Morland committed 5f4fcbc on 7.x-1.x, 7.x-2.x 
    Issue #1258910 by stovak: Move to Drupal.behavior & Drupal.settings.

  • Liam Morland committed 5f4fcbc on 8.x-2.x 
    Issue #1258910 by stovak: Move to Drupal.behavior & Drupal.settings.

  • Liam Morland committed 5f4fcbc on 6.x-2.x 
    Issue #1258910 by stovak: Move to Drupal.behavior & Drupal.settings.
hass’s picture

hass commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Fixed

File does not exists.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.