nginx HTTP service should support different restart commands

Here is the command for OS X where nginx was installed using homebrew:
/usr/local/sbin/nginx -s reload

Hi Steve,

I've written the code for this, which branch should I create the patch against?

Patch against 7.x attached

forgot to change status

Updated quotes on anarcat's suggestion

This patch breaks my install, debugging now.

This patch fixes the issue for me, because it lists the default command as first (default) and not last, which matches the c.a.o how-to for sudoers entry.

http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/5aa3e49

[EDIT] The problem with original patch was because it matched also non-init.d versions/locations, which didn't match default sudoers entry. This is also a docs candidate.

pushed to 2.x, waiting for jenkins.

merged, part of 1.3!

Unfortunately the merged patch doesn't work with non unix systems, this updated patch resolves the issue

I'm not sure I understand this patch.

Could you provide more detailed feedback/debugging info?

If there is no /etc/init.d/nginx on your server, it should just work and the patch doesn't make any difference, imo.

What is the path to the Nginx binary on your system and what is the entry in your /etc/sudoers?

@omega8cc,

The patch is for installing Aegir on OS X, with Nginx installed via Homebrew. There is no /etc/init.d on a mac.

@Deciphered, I know, but it doesn't answer my questions. The way the patch is trying to fix the issue doesn't look like a fix, but rather workaround, so we need to learn what exactly the problem is and fix it properly to avoid introducing issues for other systems (as we did for OS X).

This (untested) patch should fix the issue: http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/a208ed4

We need also this patch: http://drupalcode.org/sandbox/omega8cc/1111100.git/commit/78c8c16

I agree, the patch doesn't seem to do anything at all except change the namespace. I'll put it down to Realityloop's DrupalCon Flu ;)

Will test out those other patches shortly, thanks omega8cc.

Patch at #17 seems to do the job.

For sanity sake/smaller code, and maybe due to laziness as I had already applied this seemingly do-nothing patch, I changed the condition in patch #17 to be ($test == $default).

Didn't apply #18 because the original didn't seem to be present to be patched.

Unfortunately while the primary issue of Nginx not being reloaded has been resolved by this issue, I am still having problems with other sections, but won't post those issues here as I'd like to at least get this one issue resolved.

Oops, didn't mean to change status.

Right, #18 is safe to skip for now, as we have already rewritten that code in the meantime anyway, while #17 should work fine.

Now I need to submit a patch for 2.x, I guess, so I'm changing the version.

Patch to be ported.

Fixed in commit: http://drupalcode.org/project/provision.git/commit/569d5489b7e40bb55981d...