D7 patch

Hi

Thanks for the patch.

By checking the code I have 2 comment. One related to the format of the diff, and one with the changes you made.

1. About the changes, is it necessary to check for the "uc_credit" module to exist? It is a dependency after all.

2. About the patch. When creating a patch use the -u option, it will create a "unified" patch. It is not that this one doesn't work, it is just that at drupal standards says we should us the other one.

I am not using Ubercart on D7, moved to commerce, so I have no real place to test it. I'm leaving this open for a while, please let me know if it works for you, if it does, please mark as RTBC (as a patch submitter you are not supposed to, but lets ignore that for now). Once matrked as RTBC I'll open a D7 branch and will commit.

Thanks again ;)

Hi, I have applied the patch in the original post and then updated the module in coder which made some more changes. I have attached the additional patch.

I have tested using the NAB developer code and approved transactions create an order and declined ones print the error into the message box and return to the review page.

Not sure if these additional changes are necessary, I had already updated it before I found this issue so really just putting it up incase the original patch doesn't do enough.

So it seems to be working as expected for me I haven't gone live yet though.

Cheers
Bernie

duplicate post removed

Hi Guys

Seems like the patch in #2 works after applying patch in Original comment. Can you submit a patch that works with the latest Dev?

Also I'm looking for a co-maintainer in case you guys are interested!

Good evening from down town Eudlo on the Sunshine Coast Queensland. I am what could be considered a Drupal and Ubercart novice. I am developing an estore form my wife's florist and have so far enjoyed the experience. I would like to thankyou for the work you have done in developing the Drupal 7 version. I was wondering how can I utilise the version 6 module with the patches you have developed. I appologise for this rather dumb question and look forward to any help you can give me. Cheers Ian G

@Ian

I'm realy sorry I ca't help.
Module has been untouched for a while now and I don't user Ubercart nor D6 anymore, hope some one else can help you.

ALso, please open new "Support Request" issues, so we can keep this patches issues easy to follow.

Hi Ian,

Sorry about the late reply. I am not a developer, more of a site builder, and am not really that familiar with making patches, just enough to get by, hence I can't submit a single combined patch. I have attached my patched version of the module which you can try. Obviously this is NOT a release version or even a dev version or anything and it is up to you to make sure that it works as expected. It worked for me in test mode with the test account details supplied by the NAB. I have not used it for real transactions.

Be aware that there is very limited functionality though, it either gives an approval and moves to the complete stage or returns a fail in an error box on the checkout page.

I have not continued to a live uc store using this module due to other requirements which made the core fields used in drupal commerce more desirable. There has been a NAB transact module written for commerce.

B

I've locally branched the git repo and updated it for D7. There are 4 sequential patches ready for "git am" from the the 6.x-1.x HEAD (122421a2196c7c74897d1a7950e5416f38178e95). For the most part, this is just a cleaner version of the patches above.

If required, I can push this branch to this project.

Alas, I did this update by mistake so I haven't had a chance to test this module with a live site. I was really meant to be making/updating a HPP version.

Oops, the first two/three patches should have their descriptions updated to credit phillamb168 and BernieCram.