I have my content type setup to display amazon fields as "Link to item", but on the page it is showing images with links to the amazon item. I have tried different view modes, and all seem to show images with links instead of just links.

Comments

rfay’s picture

Status: Needs review » Active
dollares’s picture

same for me

here's a workaround

  1. install the following module: http://drupal.org/project/css_injector
  2. on the views field add your own css class e.g. "myclass" (STYLE SETTINGS -> Customize field HTML)
  3. on css_injector add the following rule:
    .myclass img {
    display: none;
    }
willvincent’s picture

Issue is present in current dev branch.

Because of lines 139 and 140 in asin.module (see below), the inline template (without the image) was no longer being used. It's now using the amazon-item.tpl.php when using this display formatter, and that template had the image included.

        // TODO: kill off amazon_inline_item. There's no reason for it to clutter the earth.
        $theme_function = $display['type'] == 'inline' ? 'amazon_inline_item' : 'amazon_item';

This patch removes the no longer used amazon-inline-item.tpl.php, and moves what it's contents were into the now used amazon-item.tpl.php

rfay’s picture

Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Status: Active » Needs review

The famous Will Vincent in Amazon Land? Yeah!

Commit privs granted...

willvincent’s picture

Thank you sir. :) I'm working on a personal project that will be leveraging this.. so I figured I might as well start ticking off issues in the queue. :)

rfay’s picture

This module gets no love from me because I don't have it in use anywhere.

You have full privs... So if you feel like using them as you work on your project it's much appreciated. As always and as you do, just work transparently in the issue queue. Thanks so much.

willvincent’s picture

My lack of sleep must have been affecting me when I posted earlier.. that patch was bogus.

So, the real issue here is that line 140 is looking for $display['type'] to be 'inline' but it will never be inline, it will be asin_inline.

THIS patch fixes that, as well as renaming the inline tpl to match the format of the other tpls:
amazon-inline-item.tpl.php >> amazon-item--inline.tpl.php

which, in turn also seems it would resolve #1342392: Theming: Can't get own tpl to work with Display Suite.

willvincent’s picture

Status: Needs review » Fixed

Commit to 7.x-1.x-dev branch.

the_g_bomb’s picture

I'll try to help out where needed. I do want to show some more love to this and amazon_store, but time has been against me, but I'll certainly try follow you about and try to review any patches you create to help get them into the module quicker.

rfay’s picture

@the_g_bomb, you have commit on this one as well as the other. Thanks for all your work on both!

-Randy

willvincent++
the_g_bomb++

willvincent’s picture

Status: Fixed » Closed (fixed)