Closed (fixed)
Project:
Amazon Product Advertisement API
Version:
7.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 Aug 2011 at 14:34 UTC
Updated:
3 Nov 2012 at 21:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
rfayComment #2
dollares commentedsame for me
here's a workaround
Comment #3
willvincent commentedIssue is present in current dev branch.
Because of lines 139 and 140 in asin.module (see below), the inline template (without the image) was no longer being used. It's now using the amazon-item.tpl.php when using this display formatter, and that template had the image included.
This patch removes the no longer used amazon-inline-item.tpl.php, and moves what it's contents were into the now used amazon-item.tpl.php
Comment #4
rfayThe famous Will Vincent in Amazon Land? Yeah!
Commit privs granted...
Comment #5
willvincent commentedThank you sir. :) I'm working on a personal project that will be leveraging this.. so I figured I might as well start ticking off issues in the queue. :)
Comment #6
rfayThis module gets no love from me because I don't have it in use anywhere.
You have full privs... So if you feel like using them as you work on your project it's much appreciated. As always and as you do, just work transparently in the issue queue. Thanks so much.
Comment #7
willvincent commentedMy lack of sleep must have been affecting me when I posted earlier.. that patch was bogus.
So, the real issue here is that line 140 is looking for $display['type'] to be 'inline' but it will never be inline, it will be asin_inline.
THIS patch fixes that, as well as renaming the inline tpl to match the format of the other tpls:
amazon-inline-item.tpl.php >> amazon-item--inline.tpl.php
which, in turn also seems it would resolve #1342392: Theming: Can't get own tpl to work with Display Suite.
Comment #8
willvincent commentedCommit to 7.x-1.x-dev branch.
Comment #9
the_g_bomb commentedI'll try to help out where needed. I do want to show some more love to this and amazon_store, but time has been against me, but I'll certainly try follow you about and try to review any patches you create to help get them into the module quicker.
Comment #10
rfay@the_g_bomb, you have commit on this one as well as the other. Thanks for all your work on both!
-Randy
willvincent++
the_g_bomb++
Comment #11
willvincent commented