Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
25 Aug 2011 at 17:09 UTC
Updated:
2 Sep 2018 at 15:48 UTC
Jump to comment: Most recent
Comments
Comment #1
brunorios1 commentedsubscribing
Comment #2
FranciscoLuz commented@brunorios1
Hey Bruno, what are you exactly subscribing for?
If you got a few minutes to spare you could review this module so it could make its way to the Drupal full project repositories.
Here is the reviewer manual http://drupal.org/node/894256
If you are not sure about what all this is, fell free to contact me at http://drupal.org/user/544192/contact and I will be happy to explain it to you in our mother tongue.
Comment #2.0
FranciscoLuz commentedminor correction
Comment #3
brunorios1 commentedHi Francisco,
Thanks for this great work!
I'm not a developer but i'll be glad to help testing and reviewing your module.
I found some errors:
1) the html codes of the checkout completion message is not converted so the user can see it:
2) i didn't found a field to enter the cpf or cnpj of the store.
3) my php editor shows a syntax error in line 80 of commerce_boleto.module
$className::setUp($obj);4) the boletophp logo is not replaced with the merchant's logo entered on the module settings.
thank you.
Comment #4
FranciscoLuz commented@brunorios1
Hi Bruno,
Thank you very much for taking the time reviewing my module.
I will be looking into the issues you have pointed out through out this week.
Just a question though on your finding #3, is it just your PHP editor that are spiting an error or is this actually causing a noticeable trouble at the module run time?
In regards to the finding #2, I actually left it out because at the time of this module creation there were no cpf/cnpj validation module for D7. I have written a cpf/cnpj validation module for D7 in the meanwhile and it has been incorporated into this module here http://drupal.org/project/brazilian_ids . But I still have to add the cpf/cnpj field to Boleto which will be doing sometime this week.
Cheers,
Comment #5
brunorios1 commented@FranciscoLuz,
in #3, is just my php editor (Dreamweaver) that shows this warning, maybe it is out of date or something like that...
no warnings in the module runtime.
another question,
i have an banco do brasil account with "carteira 18" and "convenio" with 7 digits. this is already implemented?
i readed the readme.txt but i'm confused, because i found this info saying that this is implement:
but i found this info too:
thanks.
Comment #6
FranciscoLuz commentedHi,
Yes it is implemented, I am going to update readme.txt.
Cheers
Comment #7
sreynen commentedHi FranciscoLuz,
Commerce projects often take a long time to be approved because few people know enough about Commerce yet to do reviews. I'd encourage you to go where people are talking about Commerce and encourage them to come here and help review your project. Some places you might ask for reviews:
http://groups.drupal.org/drupal-commerce
http://www.drupalcommerce.org/forum
The #drupal-commerce IRC channel
Comment #8
sreynen commentedSee: http://drupal.org/node/1246104#comment-5092040
Comment #9
FranciscoLuz commentedComment #10
brunorios1 commentedAfter all, i'm not using the last commerce-boleto module code from git, because the banks are not loaded in the payment method configuration as i described here: http://drupal.org/node/1379508
as i mentioned before in #3, the line 80 have problems:
$className::setUp($obj);the error is:
i tried to change to:
$this->setUp($obj);but it shows:
Thanks!
Comment #11
brunorios1 commentedany news about this module?
Comment #11.0
brunorios1 commentedremoved link
Comment #12
avpaderno@brunorios1 See the duplicated application.