When adding a view of type "Relation", you get quite a bit of error messages. The most important is probably in the field handler, saying it is missing relation.table.

It would be nice to have Relation view type, but in lack of that it would make sense to remove that view type alltogether.

CommentFileSizeAuthor
#10 relation-7.x-1.x-1260236-10.patch9.5 KBseandunaway
#3 views-test.txt6.01 KBdawehner
#2 1260236-proper-relation.patch3.99 KBdawehner
#1 1260236-proper-relation.patch3.38 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Assigned: Unassigned » dawehner
StatusFileSize
new 1260236-proper-relation.patch3.38 KB

Here is a first patch + assign for myself.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1260236-proper-relation.patch3.99 KB

Here is a real patch which provides proper views integration for the relation base table.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new views-test.txt6.01 KB

Here is a test view i created, which could perhaps be used by a views test.

itangalo’s picture

itangalo commented
Status: Needs review » Needs work

The view now loads fine, but the field handler "enpoints" won't render anything. (It seems to collect the information though, since it recognizes how many endpoints each relation has.)

Don't know if this is a new feature request or not, but I'm gambling and changing this to "needs work".

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented

I can't seem to get this view type at all, am I missing something?

Remon’s picture

Remon commented

subs!, views of type relation are completely broken atm.

Remon’s picture

Remon commented

I second @Itangalo, all fields work properly except for "Relation: Endpoints". Actually views' query doesn't seemto JOIN with field_data_endpoints table.
Thanks for the great effort guys!

dawehner’s picture

dawehner
Primary language German
commented

@Itangalo
Let's get this part in and then fix the rest, the endpoints stuff should perhaps be fixed in #1260252: View relationship "relation -> entity"

itangalo’s picture

itangalo commented
Status: Needs work » Reviewed & tested by the community

@dereine: I think the thing with missing endpoints table in the view is separate from #1260252: View relationship "relation -> entity", but it is also separate from this issue. (I think it's due to how relation_endpoints works.)

Starting a new issue about that. This issue is now solved.

seandunaway’s picture

seandunaway commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new relation-7.x-1.x-1260236-10.patch9.5 KB

Rerolled patch with first attempt at a test for this.

dereine, is there a way to reset a view, including removing results, after execute()?

seandunaway’s picture

seandunaway commented
Status: Needs review » Fixed

[7.x-1.x-1260236 6c7f787] Issue #1260236 by dereine: Provided proper views integration for the relation base table.
1 files changed, 138 insertions(+), 0 deletions(-)

[7.x-1.x-1260236 063321c] Issue #1260236 by rump: Tests for relation base table views integration.
1 files changed, 46 insertions(+), 10 deletions(-)

Committed.

seandunaway’s picture

seandunaway commented
Title: View type "Relation" is pretty badly broken » Provide proper views integration for the relation base table.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.