By Andrev-1 on

I've been playing around with Drupal now for about 24 hours and I am a newb with the software. What I am trying to accomplish is fairly straight forward. I want to use an Image instead of Text as the forum title. I run into a problem when I type straight HTML into the field and save. What happens is that the HTML code is saved to the database correctly, but when it goes through the Theme() function, the brackets (<.....>) get stripped off. I looked at the Theme() function and well I dont code OOP yet. So I am having a substantially difficult time figuring out where there may be a replace for my HTML code.

Can anyone help me?

⋅ Categories: Drupal 5.x

Comments

mfer’s picture

mfer commented

Are you saying that you want the title of each forum to be an image? Is this true for each forum title?

Like:
- General (a section and the title is an image)
-- Post 1 (title is image)
-- Post 2 (title is image)

And, are you looking for the these images to be more than text in a different font than you can use with the web?

--
Matt
http://www.mattfarina.com

Andrev-1’s picture

Andrev-1 commented

What I want specifically is:

Container Title as [text or image]
--Forum 1 Title as [text or image]
--Post Title as Text
--Forum 2 Title as [text or image]
--Post Title as Text

etc...

I am volunteering my time to help a friend of mine with his site at http://www.woldiangames.com. The site has images as the forum titles. Go visit and look in the golden arena and you will see what I mean.

I want to use an <img src="........"> in order to make the title of the forum into an image. What I am seeing when I do this is that the HTML brackets get stripped off when they run through the themeing functions.

jmarkantes’s picture

jmarkantes commented

You should look into the signwriter module. It can create all kinds of text graphics on the fly, with caching for previously generated images.
J

Andrev-1’s picture

Andrev-1 commented

So I went into the code to check this out, the forum function that controls the way the forum is displayed is here:

function theme_forum_list($forums, $parents, $tid) {
  global $user;

  if ($forums) {

    $header = array(t('Forum'), t('Topics'), t('Posts'), t('Last post'));

    foreach ($forums as $forum) {
      if ($forum->container) {
        $description  = '<div style="margin-left: '. ($forum->depth * 30) ."px;\">\n";
        $description .= ' <div class="name">'. l($forum->name, "forum/$forum->tid") ."</div>\n";

        if ($forum->description) {
          $description .= ' <div class="description">'. filter_xss_admin($forum->description) ."</div>\n";
        }
        $description .= "</div>\n";

        $rows[] = array(array('data' => $description, 'class' => 'container', 'colspan' => '4'));
      }
      else {
        $new_topics = _forum_topics_unread($forum->tid, $user->uid);
        $forum->old_topics = $forum->num_topics - $new_topics;
        if (!$user->uid) {
          $new_topics = 0;
        }

        $description  = '<div style="margin-left: '. ($forum->depth * 30) ."px;\">\n";
        $description .= ' <div class="name">'. l(.'<img src=".'$forum->name'.">.', "forum/$forum->tid") ."</div>\n";
        
        if ($forum->description) {
          $description .= ' <div class="description">'. filter_xss_admin($forum->description) ."</div>\n";
        }
        $description .= "</div>\n";

        $rows[] = array(
          array('data' => $description, 'class' => 'forum'),
          array('data' => $forum->num_topics . ($new_topics ? '<br />'. l(format_plural($new_topics, '1 new', '@count new'), "forum/$forum->tid", NULL, NULL, 'new') : ''), 'class' => 'topics'),
          array('data' => $forum->num_posts, 'class' => 'posts'),
          array('data' => _forum_format($forum->last_post), 'class' => 'last-reply'));
      }
    }

    return theme('table', $header, $rows);

  }

}

Now I modified the above code to try to force an image into the link. However, I messed up somewhere in the syntax, because PHP says it is expecting a ')' and is getting a ',' .

The line modified is

$description .= ' <div class="name">'. l(.'<img src=".'$forum->name'.">.', "forum/$forum->tid") ."</div>\n";

Anyone see the error or know more about the link function defined by the L()? I sure could use some help here.

Regards,

Steve

Andrev-1’s picture

Andrev-1 commented

This is Solved. You can make the forum link IMAGE based by going into the common.inc core file.

FIND:

function l($text, $path, $attributes = array(), $query = NULL, $fragment = NULL, $absolute = FALSE, $html = FALSE) {
  if ($path == $_GET['q']) {
    if (isset($attributes['class'])) {
      $attributes['class'] .= ' active';
    }
    else {
      $attributes['class'] = 'active';
    }
  }
  return '<a href="'. check_url(url($path, $query, $fragment, $absolute)) .'"'. drupal_attributes($attributes) .'>'. ($html ? $text : check_plain($text)) .'</a>';
}

and change the variable $html = FALSE to $html = TRUE.

Basically the function will html encode the link changing a (") int &quot, etc.. I tried just adding an $html=TRUE to the link function call.. ie l($forum->name, "forum/$forum->tid", $html=TRUE) , but that did not work. I had to change it in the common.inc file.

mfer’s picture

mfer commented

Don't do this... it's hacking the core. All of this is themable without making changes to the core files. If you change them maintenance just became a real pain.

Instead use a page-forum.tpl.php page, a node-forum.tpl.php page, and contemplate to get what you want in a look. In this case it's proper usage of the page-forum.tpl.php file.

--
Matt
http://www.mattfarina.com

Andrev-1’s picture

Andrev-1 commented

I do not believe this is themeable. What I want is essentially a script that will parse through the database and show the images instead of the text for each forum. If you can explain to me how this is themeable with an example, I will gladly do that instead of changing a core file.

joeking’s picture

joeking commented

The thing is after 24hrs you are thinking of messing with the core - could come back to haunt your friend when you're long gone.

Rob_Feature’s picture

Rob_Feature commented

I agree with Matt. This can, pretty simply, be done by using Contemplate and CSS.

Theme functions should always remain theme functions. You shouldn't use drupal itself to change display...there's always a theme-way to do it.

/**
  * Bob Christenson
  * Mustardseed Media
  * http://mustardseedmedia.com
  */
patricksettle’s picture

patricksettle commented

if ever a good idea.

This is true, hacking core files can be problematic. But one thing I'm curious about is why isn't $html = TRUE working? It seems from the API docs that should work for them, but it isn't. I'm trying to use it to add a simple span, and it's not working as expected either. l() api docs say that if the $text is html such as in the case of using and image for the link, that I can use $html = TRUE for it not to plaintext it and expose the html code. Yet it doesn't work.

Anyone have any suggestions as to why it's not?

patricksettle’s picture

patricksettle commented

Um... because I had one too many ,NULL 's thats why. *sigh*

SO... a solution for the Op

Use this:

 l($forum->name, "forum/$forum->tid", NULL, NULL, NULL, NULL, TRUE)

It worked for me. under 5 (I think it's the same under 4.7, check api.drupal.org to be sure)...

rvk’s picture

rvk commented

I tried this for Drupal 6, but without success. Anyone know how to set html to true in D6?
I'm also using contemplate and the function l()

My knowledge of php is limited...