Hi,
First of all, thanks for the great module, we're looking to use it for tracking the popularity of terms (and external links using a simple custom module), I've installed it on Drupal 7.7.

I'm getting this error in my log:

Notice: Undefined index: in RadioactivityLiveIncidentStorage->addIncident() (line 41 of /web/wamuseum/www/sandbox7/sites/all/modules/contrib/radioactivity/includes/RadioactivityLiveIncidentStorage.inc).

Getting this in my log for every view of a term with a radioactivity field. The energy value never changes from 0 no matter how many times I view it at it's term page (/tags/{term}). I also have a different Radioactivity field attached to a node that is working correctly.

From looking at the code, maybe it's not getting the language from the term?

Comments

tcmug’s picture

tcmug commented
Status: Active » Needs review

Give the master one a spin and see if that fixes it for you.

I'm not sure but there seems be an issue with field_attach functions and taxonomy entities not working properly but I never got around to test it any further. That said, I rewrote the function that adds the energy (in the Live storage) to use db_merge instead. So, that kinda works, but its scary :)

andrew-r’s picture

andrew-r commented

I updated to latest dev and the terms are now getting energy, awesome!

FYI, I'm using live storage but I got curious and thought I'd test the deferred method so I changed the settings for the existing profile, and I got these warnings after viewing some random terms and then running cron:

Notice: Undefined property: stdClass::$language in RadioactivityDeferredIncidentStorage->processIncidents() (line 69 of /web/wamuseum/www/sandbox7/sites/all/modules/contrib/radioactivity/includes/RadioactivityDeferredIncidentStorage.inc).
Notice: Undefined index: in RadioactivityDeferredIncidentStorage->processIncidents() (line 84 of /web/wamuseum/www/sandbox7/sites/all/modules/contrib/radioactivity/includes/RadioactivityDeferredIncidentStorage.inc).
Notice: Undefined index: in RadioactivityDeferredIncidentStorage->processIncidents() (line 85 of /web/wamuseum/www/sandbox7/sites/all/modules/contrib/radioactivity/includes/RadioactivityDeferredIncidentStorage.inc).

Status message

Updated 2 fields and culled 0 fields of field_data_field_term_rad
Cron ran successfully.

The "radioactivity_deferred_storage" table is being populated with term and node entries, I ran cron and after getting the above warning, the term entry disappears and subsequent cron runs do not generate any warinings. The node entries are not being removed from the "radioactivity_deferred_storage" and no new energy is being added to the terms or nodes.

Hope this info is helpful, let me know if you want me to try any more tests, I'll go back to using live storage but if you need me to, I'll switch back and test.

Thanks for your help.

tcmug’s picture

tcmug commented

Gee, should've seen that one coming :)

Both of the storage types use the same method to update energies now.

Fix is in the master now!

tr’s picture

tr commented
Issue summary: View changes
Status: Needs review » Fixed

"Fix is in the master now!"

It seems this was probably fixed long ago.

Regardless, Drupal 7 is no longer supported, and the Radioactivity code in Drupal 8+ is significantly changed. There have been no further reports of a problem like this for the past 13 years.

tr’s picture

tr commented
Status: Fixed » Closed (fixed)