Add a hook_commerce_payment_methods_alter()

Updated the misleading title.

#1258386: hook_commerce_payment_method_info() now requires 'active' field. marked as duplicate

I'm also getting this error

from commerce/modules/payment/commerce_payment.module

  // Then load the Rule configuration that enables the method.
  $rule = rules_config_load($rule_name);

  // Iterate over its actions to find one with the matching element ID and pull
  // its settings into the payment method object.
  $payment_method['settings'] = array();

  foreach ($rule->actions() as $action) { // <-- $rules is not an object, I believe it's null
    if ($action->getElementName() == 'commerce_payment_enable_' . $method_id) {
      if (is_array($action->settings['payment_method']) && !empty($action->settings['payment_method']['settings'])) {
        $payment_method['settings'] = $action->settings['payment_method']['settings'];
      }
    }
  }

So I'm wrapping this code with an empty() statement for now as a work around

 // Then load the Rule configuration that enables the method.
  $rule = rules_config_load($rule_name);

  // Iterate over its actions to find one with the matching element ID and pull
  // its settings into the payment method object.
  $payment_method['settings'] = array();
  if(!empty($rule)) {
  foreach ($rule->actions() as $action) { // <-- $rules is not an object, I believe it's null
    if ($action->getElementName() == 'commerce_payment_enable_' . $method_id) {
      if (is_array($action->settings['payment_method']) && !empty($action->settings['payment_method']['settings'])) {
        $payment_method['settings'] = $action->settings['payment_method']['settings'];
      }
    }
  }
}

Seems to be working in the right direction.

Problem is now, I can't reach the defaulted display_title or title values.

Does this alter perhaps need to be moved down a little?

EDIT:

Confirmed, I can't change display_title variable of the payment methods from this new hook. So it's not useful for me. I'd need to do it by hacking the payment module or using HOOK_commerce_payment_method_info_alter().

Any other suggestions?

Ya, I really need to be able to access the configuration in hook_commerce_payment_method_info_alter(), as this is the information that's used for display.

I can do it in form_alter(), but I have a problem with being able to identifying the payment methods are they're key'd in that weird pipe format.

$form_id == 'commerce_checkout_form_checkout';
$form['commerce_payment_method'] =
  payment_method (Array, 4 elements)
    #type (String, 6 characters ) radios
    #options (Array, 4 elements)
      paypal_wpp|commerce_payment_paypal_wpp (String, 11 characters ) Credit card
      paypal_wps|commerce_payment_paypal_wps (String, 10 characters ) PayPal WPS
      commerce_cheque|commerce_payment_commerce_cheque (String, 6 characters ) Cheque
      commerce_payment_example|commerce_payment_commerce_payment_example (String, 15 characters ) Example payment

The ideal way would be to pass in the payment configuration into hook_commerce_payment_method_info_alter() so the developers have all the information they'll need to modify it accordingly to their particular needs. Having the order in there would be nice too. Not sure if this is feasible, but with out it, we're pretty much forced to use the default payment gateways display information with out major hackery.

I might have a patch.

The problem is you keep calling commerce_payment_method_load() which doesn't have the changes made via hook_commerce_payment_methods_alter() and it overrides them. You seem to only be trusting the data which comes via commerce_payment_method_load(). In order to make this work, the code needs a re-factor.

I would do this myself, but I have a feeling anything I do may have un-intended consequences.

With that said, I have a proposed solution. You need to trust the data $order->payment_methods. We also need to load the payment_method information which is loaded via the rule in there as well. Then you'll need to prune out the potentially bad (or disabled) payment modules. Although, you may just be being over diligent in the code. I'm not sure.

If you wanted to go this route, I've added a patch. After this patch, if you always use the information in $order->payment_methods in the function commerce_payment_pane_checkout_form(), we should be good as far as I'm concerned.

---
Caveat: If you use this patch data in commerce_payment_method_load() can't really be trusted, as it's not modified. Ideally commerce_payment_method_load() would return the proper modified data.

Let me know if you need additional elaboration.

Updated my module to work with -dev.

Here's the code:
http://drupal.org/project/commerce_payment_icons

I do think my example provides a much better user experience as it's much more clear to the end user what processor is used for what.

In my opinion, the best method for UX would be for each processor to define these elements. For those who create processors, it should be required that they define these elements.

• a name for the processor
• some icons for the processor
• a short description (in HTML) which would be displayed below the name and icons

The site builder, then needs to be able to override all of these. Ideally this could be done via a UX, but if not a proper hook could be provided to do it in code. Thus the site builder has full control of what the best method is to display and describe each processor they have enabled on their site.

Like for example, I'm not a huge fan of displaying "Paypal WPS" and would much rather have it just say "Paypal". Currently there no easy way to change this.

Currently there's no appropriate hook to do so and it becomes fairly hacky as my module demonstrates.

I'd also like the old Security Code description popup which Ubercart had. Currently I believe some users won't understand what to put in there.