As per chx battle plan

Patch probably needs work, but setting to needs review to see if this doesn't break tests (can't imagine honestly) as I haven't touched the toolbar code yet - need to investigate that 'drawer' concept in there. But it's a starting point to see if Dries is up with this.

I'm up to maintain this in contrib (or in core if needed).

Comments

swentel’s picture

StatusFileSize
new86.32 KB

Updated patch removing css/js/code from bartik, seven and overlay as well.

itangalo’s picture

Respect for offering to maintain this is contrib.

If it is of any concern, my experience of the Shortcut module is that I haven't seen anyone actually using it – and I've seen quite a few new Drupallers thoughout my courses. (Them not using Shortcut may of course be a result of my training, but I usually do show how to use it – even if I don't use it myself.)

I'm not capable of deciding whether Shortcut should be in core or not – and I don't really have an opinion myself – but hopefully this piece of information may be of use to someone.

Bojhan’s picture

I do think we need to postpone this issue, there has not been consensus anywhere that this needs to be removed.

Since this is such a new feature, that has only seen minimal usability testing and/or optimization. As I mentioned in other threads I think improvements to the toolbar might make the shortcut module obsolete, but we are not at that point yet.

chx’s picture

There's a contrib for this but I am sure it'd be happy to continue existing under keyboard_shortcut. There's a whole of 52 sites using it, the last commit was a year ago... that's a dead one.

damien tournoud’s picture

StatusFileSize
new389 bytes

I agree with Bojhan here. What about this?

gdd’s picture

Status: Needs review » Reviewed & tested by the community

+1 to Bojhan and Damz, swentel said he agrees

catch’s picture

Title: Remove shortcut from core » Add swentel as shortcut maintainer
Component: toolbar.module » shortcut.module

Let's update the issue title...

chx’s picture

I am fine with this course of events.

klausi’s picture

StatusFileSize
new388 bytes

Don't use "https" in the link for consistency.

dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x.

David_Rothstein’s picture

If it is of any concern, my experience of the Shortcut module is that I haven't seen anyone actually using it...

I actually see people use this a lot - whenever I log in to a Drupal Gardens site to help someone with a problem, I naturally get to see their shortcut bar at the top of the page. A significant percentage of those users have customized their shortcut bar (tough to estimate exactly how many, but I see it a lot). Many use it so much that they are running into #682000: Remove the default limit of 7 shortcuts per shortcut set; we know that from direct feedback (see that issue), but also anecdotally I can tell you that I happen to see exactly seven shortcuts on a lot of those people's sites :)

Those are power users, though (which is sort of the primary audience for the module); I think where it's failing to be used is by newer users, who could still benefit from it. We have decent evidence from #1164782: The icon to add something to shortcuts wasn't clearly discoverable. that new users are not discovering it as quickly as they could.

As I mentioned in other threads I think improvements to the toolbar might make the shortcut module obsolete, but we are not at that point yet.

If you look at e.g. computer operating systems, almost all of them have a customizable shortcut feature on the Desktop (which is separate from the "standard admin menu"). Based on that it I doubt it would make sense to remove this module from core as long as Toolbar is in core - they serve somewhat complementary purposes. Trying to merge in this functionality to the toolbar doesn't seem like a good idea either, for several reasons (among them people would not be able to easily turn the shortcuts off if they want a less intrusive toolbar instead).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.