Convert menu_get_object('node') to context

Working on it.

Current problem: menu_get_item() is invoked before the hook_init() implementations, but the hook_context_init() invocation happens in system_init(), which is one of the hook_init() implementations.

#1261068: Fire the context_init hook before the session starts. is fixing that.

First attempt..

Oopsie wrong git diff.

I've been working on it differently, but I have a problem setting the context: this works on butler D7, but not on the WSCCI sandbox.

What is happening is that when I addLayer() to add a new value before locking it, the new version of addLayer returns a tracker, and it is released at the end of the function adding it, causing the destructor to trigger, and remove the layer just added. Of course, going like this works around the problem:

$context = drupal_get_context().
$tracker = $context->addLayer();
// add value and lock
unset($tracker->context); // __destruct() checks whether context is set to delete it
return;

But this feels just silly, since the whole point of the added tracker, which was not present in butler, seems to be to remove added contexts.

The somehow-funny bit is that even just adding a dsm($tracker); will prevent php from unsetting it and make the code work, which is an unexpected side-effect.

This is when the loaders are being called in menu.inc: at this point, the loader for the leftmost wildcard in the page arguments loads an object from the db, and defines what will (in current drupal) be the result of menu_get_object(), i.e. the entity (node, user, taxonomy_term...) context which menu_get_object will return later.

So what I do it use this object while it has just been loaded, and push it to the context so that later references to $context[$entity] will trigger a getValue() that will only fetch values pushed once from the context definition point instead of going to pull them at the time of reference. Which seems to be the whole point of the mechanism in the first place: compute the context data initially, and just fetch them later, sure that they have not changed, instead of having to requery or access a cached result. Or am I misguided ?

So here is a new version. It handles all current cases of menu_set_object() in core, not just menu_get_object('node'), and all unit tests I've checked pass

Still, I'm under the impression I'm doing things backwards, even though everything works.

Note that it applies on top of commit 3ebcfee, apparently not on top of the current head, the reason being that it uses module_invoke_all('entity_info'); which is not available after commit 39f6f3, which converts hook_context_init() to a bootstrap hook.

Postponed until the HTTP handling is in.

Per catch, and blessed by Larry, moving this and all other WSCCI issues to the Drupal core queue.

I tried to re-roll fgm's patch #10, but I encountered a problem. Basically, fgm told me that I only needed to change $context['node'] to $context->getValue('node'), and modify the paths in the patch file so it could apply. But there's a missing function : system_context_init() is not anymore in the system module. As I didn't follow wscii's development, I don't really know what replaced it. And fgm's comment #10 confuses me as it says hook_context_init() has been replaced, but as I see it in the code it stills exists...

Important, I tried to apply this patch against Crell's big merge patch #33 in #1233232: Add unified context system to core.

Thanks for the explanation. We'll wait until the main patch goes in, it will be easier indeed.