Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
language system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Aug 2011 at 20:52 UTC
Updated:
29 Jul 2014 at 19:55 UTC
Jump to comment: Most recent file
Comments
Comment #1
attiks commentedAttached a patch that changes the description, the patch depends on #1250800: Language domain should work regardless of ports or protocols, so that one has to go in first.
Comment #2
gábor hojtsyThis sentence does not compute for me: "URL to use for this language, do not any protocol, nor any port.".
Comment #3
attiks commentedGabor, something like this:
Domain name to use for this language, do not use any protocol (like http://) or a port (like: 88).
1 days to next Drupal core point release.
Comment #4
gábor hojtsyWell, we previously suggested they MUST provide a protocol, right? So what about just saying that the language detection is independent on protocol or port, and let them provide it for backwards compatibility / if they want it anyway. The code change should be backwards compatible anyway. BTW why not do this in the same issue as #1250800: Language domain should work regardless of ports or protocols? I don't see them being unrelated.
Comment #5
attiks commentedDomain name to use for this language, you may optionally specify a protocol or a port, but the language will be detected based on only the domain name.
Comment #6
attiks commentedComment #7
gábor hojtsyTagging, fixing title.
Comment #8
yoroy commentedA first rewrite:
- Removed the 'don'ts': No need to talk about the things that happen automatically anyway.
- Shorter, single example
- Maybe 'Detection and selection' should be a link to that settings page? Not sure.
Comment #9
attiks commented@yoroy, what they have to enter isn't technically a URL, they have to enter a domain name:
Comment #10
yoroy commentedWell, that part I did not change ;-p
In that case, domain is indeed better.
Comment #11
attiks commentedso we have
Comment #12
yoroy commentedStill pretty long, but yes.
Comment #13
attiks commentedupdated patch
Comment #14
gábor hojtsyLooks good to me. Still think this should be rolled into #1250800: Language domain should work regardless of ports or protocols, or if not, marked postponed on that. That issue makes it work as described here, so I think easier would be to get the two in at once.
Comment #15
attiks commentedDone