http://drupal.org/project/issues/civicrm_member_plus_rolesI get this message in reports after logging out

Warning: Parameter 1 to civicrm_member_plus_roles_user_logout() expected to be a reference, value given in module_invoke_all() (line 819 of/usr/local/share/drupal/v7/core/drupal-7.7/includes/module.inc).

Comments

kreynen’s picture

kreynen commented
Version: » 7.x-1.x-dev
Status: Active » Fixed

fixed.

http://drupalcode.org/project/civicrm_member_plus_roles.git/commit/d37e974

This is actually an issue with the way CiviCRM implements hook_user_login and hook_user_logout in the original civicrm_member_roles

http://api.drupal.org/api/drupal/modules--user--user.api.php/function/ho...
http://api.drupal.org/api/drupal/modules--user--user.api.php/function/ho...

Was...

/**
 * Implementation of hook_user_login().
 */
function civicrm_member_plus_roles_user_login( &$edit, &$account ) {
    civicrm_member_plus_roles_sync_user( $account );
}

/**
 * Implementation of hook_user_logout().
 */
function civicrm_member_plus_roles_user_logout( &$account ) {
    civicrm_member_plus_roles_sync_user( $account );
}

Should be...

/**
 * Implementation of hook_user_login().
 */
function civicrm_member_plus_roles_user_login( &$edit, $account ) {
    civicrm_member_plus_roles_sync_user( $account );
}

/**
 * Implementation of hook_user_logout().
 */
function civicrm_member_plus_roles_user_logout( $account ) {
    civicrm_member_plus_roles_sync_user( $account );
}

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.