Closed (fixed)
Project:
Freelinking
Version:
6.x-3.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Aug 2011 at 14:16 UTC
Updated:
14 Oct 2014 at 08:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
navik commentedIn freelinking.module
Change
'/(?<!\\\\)\[\[([A-Za-z0-9]{1}.+' . $separator . '?.+)]]/Uu';to
'/(?<!\\\\)\[\[([A-Za-z0-9]{1}.+' . $separator . '?.+|.+)]]/Uu';Thanks xandeadx (http://xandeadx.ru)
Comment #2
misc commentedAttached patch for the above fix.
Comment #3
rhblake commentedI had a similar problem when a Swedish character (åäö) was the first character of a node title. E.g., [[Göran Persson]] would work but not [[Örjan Persson]]. This patch solved it. Thanks!
Comment #4
misc commented@rhblake, I mark as reviewed & tested by the community, if you think this is wrong, but it back in need review.
Comment #5
juampynr commentedCommitted: http://drupalcode.org/project/freelinking.git/commitdiff/3c878d8
Needs backport to 6.x-3.x.
Comment #6
torbasow commentedThis patch is not quite correct. Hasn’t anyone noticed that /(?<!\\)\[\[([A-Za-z0-9]{1}.+\:?.+|.+)]]/Uu fully equivalent to simplier /(?<!\\)\[\[(.+)]]/Uu?
It should be /(?<!\\)\[\[(([A-Za-z0-9]{1}.+\:)?.+)]]/Uu, I think. The quantifier ? must be applied not to only : but to pluginname: entirely.
Comment #7
juampynr commentedMoved to 6.x-3.x branch so it can be ported.
Torbasow, could you post here some examples of why this pattern is wrong?
Comment #8
rsvelko commentedthe patch from #2 fixed it for me on a drupal 6.25 with freelinking 3.2. for cyrillic.
Comment #9
gisleIt looks like this has been fixed somewhere along the way.
I am unable to reproduce this when testing version 6.x-3.4.