Hello.

First of all congratulations for the module it was a very good idea.

However I am having a problem setting up the module in themes configuration page: admin/build/themes/settings/themename.
I fill up all the css files I want to include (these from my .info file)
and when I click save nothing happens. I am building a custom theme with zen so I tried with garland with same results.

Is there any way I can do that through database?

Basically .... now I notice that if the module is enabled you can't click any "save configurations" button in admin/build/themes/settings page...

I don't know if it is relevant but I am also getting a warning in admin pages:
Warning: syntax error, unexpected $end, expecting ']' in /tmp/browscap_localhost.ini on line 51 in _browscap_import() (line 349 of .../sites/all/modules/browscap/browscap.module).

Comments

chefarov’s picture

chefarov commented
Issue summary: View changes

removed some < > tags

markhalliwell’s picture

markhalliwell
Primary language English
commented

It sounds as if you're running PHP 5.3? This module relies heavily on Browscap, so if you're having issues you might try fixing Browscap first... there are some patches in #664424: Values returned as bool with PHP < 5.3 should also be bool with PHP >= 5.3.

chefarov’s picture

chefarov commented

Hello Mark.
Thank you for your quick reply.

I followed the guidelines from the issue link you posted and the browscap part seems fixed now since the warnings are completely gone after that!

However problem with the "Save Configurations" button still exists.
I tried unistalling and re-installing the module, no luck.

markhalliwell’s picture

markhalliwell
Primary language English
commented

Please post the version of jQuery Update you are using. If you use Firebug, please also include any JavaScript errors that are generated when clicking the button. Thanks!

chefarov’s picture

chefarov commented

I am using Jquery update 6.x-2.0-alpha
The only error I can't find with firebug(when I click the button) is in "XHR" tab where it says:

POST save 404 not found
with url:
http://localhost/browser_theme/save
...

By the way Browscap is working fine now since it is grabbing information about my browsers.

chefarov’s picture

chefarov commented

I am using Jquery update 6.x-2.0-alpha
The only error I can't find with firebug(when I click the button) is in "XHR" tab where it says:

POST save 404 not found
with url:
http://localhost/browser_theme/save
...

By the way Browscap is working fine now since it is grabbing information about my browsers.

markhalliwell’s picture

markhalliwell
Primary language English
commented

I just did a complete install on a new site and I was able to save just fine. The only thing that I can surmise is that your browser can not find http://localhost/browser_theme/save

I see you're using localhost... perhaps there's something going on there? It sounds like it's a DNS resolution (IDE) issue.

chefarov’s picture

chefarov commented
Status: Active » Closed (cannot reproduce)

I just uploaded the website to my server and I have the same problem.
Anyway I will just use the proper javascript code by hand.
Thanks for your time.

chefarov’s picture

chefarov commented

I just uploaded the website to my server and I have the same problem.
Anyway I will just use the proper javascript code by hand.
Thanks for your time.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Closed (cannot reproduce) » Needs work

What "proper" JavaScript code? If you have a solution, you should share your findings not close the ticket. If anything it would help me understand maybe what you are talking about in more detail.

chefarov’s picture

chefarov commented

Hello.

By "proper" I mean some code to detect browser/version/OS and include some specific css files for each one.
I haven't figured it out yet exactly because of the common conflict with enabled cache (see comments here and a possible workaround here.
Also there are the following modules which could help I think:
browser class
Css Browser selector

But this is irrelevant with the issue here... The issue is about a non-clickable button not the browser detection technics I think.

markhalliwell’s picture

markhalliwell
Primary language English
commented

When you say "non-clickable" what exactly do you mean? That you press it and nothing happens? Or that it's disabled? I'm rather a little confused and a bit perplexed as to why you cannot get this module to work. Could you please post your server's status report so I can see what versions of the requirements you are running?

I know that you are probably not wanting to pursue this further, however it would be nice to figure out what's going on to either update documentation in more detail or fix the module.

As far as the purpose of this module, it only provides separate browser based template suggestions for both CSS and JS. This helps when there is a tremendous amount of customization needed, with respected separate files.

Generally people run into issues after the this module has been configured because of page caching (see project page). This is the first time I've run into the actual module's settings not working properly.

chefarov’s picture

chefarov commented

Hello Mark.

I was not sure If I provide you with the correct information so I uploaded the working site here:
http://147.27.23.52/flck
so that you can login as an admin
with username: admin
pass: admin123
and take a look for yourself. The site is in greek but I have installed the administrator menu module so you shouldn't have a problem. The Browser theme settings module is enabled, and I have switched back to garland and you can see what I mean by visiting http://147.27.23.52/flck/admin/build/themes/settings and trying to click "save configurations" button.

Thanks again.

My final guess is that it may be something wrong with my custom theme I am building (based on Zen) that conflicts or sth like that. I am sorry if this is not a bug of the module and I have misundrerstood this.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Fixed

Ahhh! This is indeed a bug :( A pretty simple overlook on my part. You have a Drupal installation in a subdirectory of "flck" so when the button is clicked, it was looking for: "/browser_theme/save", not: "/flck/browser_theme/save". Thank you for pointing this out! I rarely install in subdirectories, so it did work on a root install lol

I have gone ahead and committed this fix to the latest release 1.9. Download at your leisure :)

PS: don't forget to change your credentials :)

chefarov’s picture

chefarov commented

Thank you very much Mark. Good job :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

more info