Tax is not showing in order summary, fix supplied

Tax is not showing in order summary

regarding:
// $Id: tax.module,v 1.16.2.4.4.7 2007/02/27 06:53:51 sime Exp $

in the function function tax_checkoutapi()

change this:

  foreach ($rules as $rule) {
	switch ($rule->realm) {
	  case 'city':
		if (drupal_strtoupper($billing->city) == $rule->realm_value && tax_rule_product_match($txn, $rule)) {
		  if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			$total_tax += $tax;
		  }
		}
		break;
	  case 'country':
		if (drupal_strtoupper($billing->country) == $rule->realm_value && tax_rule_product_match($txn, $rule)) {
		  if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			$total_tax += $tax;
		  }
		}
		break;
	  case 'state':
		if ($billing->state) {
		  if (drupal_strtoupper($states[$billing->state]) == $rule->realm_value && tax_rule_product_match($txn, $rule)) {
			if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			  $total_tax += $tax;
			}
		  }
		}
		break;
	}
  }

to (removed drupal_strtoupper() 3 times):

  foreach ($rules as $rule) {
	switch ($rule->realm) {
	  case 'city':
		if ($billing->city == $rule->realm_value && tax_rule_product_match($txn, $rule)) {
		  if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			$total_tax += $tax;
		  }
		}
		break;
	  case 'country':
		if ($billing->country == $rule->realm_value && tax_rule_product_match($txn, $rule)) {
		  if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			$total_tax += $tax;
		  }
		}
		break;
	  case 'state':
		if ($billing->state) {
		  if ($states[$billing->state] == $rule->realm_value && tax_rule_product_match($txn, $rule)) {
			if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			  $total_tax += $tax;
			}
		  }
		}
		break;
	}
  }

or (added drupal_strtoupper() 3 times):

  foreach ($rules as $rule) {
	switch ($rule->realm) {
	  case 'city':
		if (drupal_strtoupper($billing->city) == drupal_strtoupper($rule->realm_value) && tax_rule_product_match($txn, $rule)) {
		  if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			$total_tax += $tax;
		  }
		}
		break;
	  case 'country':
		if (drupal_strtoupper($billing->country) == drupal_strtoupper($rule->realm_value) && tax_rule_product_match($txn, $rule)) {
		  if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			$total_tax += $tax;
		  }
		}
		break;
	  case 'state':
		if ($billing->state) {
		  if (drupal_strtoupper($states[$billing->state]) == drupal_strtoupper($rule->realm_value) && tax_rule_product_match($txn, $rule)) {
			if ($tax = tax_calculate($taxable_amount, $rule->operand, $rule->operator)) {
			  $total_tax += $tax;
			}
		  }
		}
		break;
	}
  }

Both options work, adding drupal_strtoupper() (suggestion 2) may be saver but generates some extra function calls.

Regards, Jos