I'm using nodetitle as the default plugin with search as the fallback. When I have double brackets around a multi-word phrase that doesn't map to an existing node title, the spaces in the link text get replaced with plus signs.

Attached is a patch but I don't know if the 'target' element is always set so I'm not sure if this is the correct fix.

CommentFileSizeAuthor
search-link-text.patch760 bytesjustmagicmaria

Comments

misc’s picture

misc commented
Status: Active » Needs review
mattbk’s picture

mattbk commented

This patch removes the plus sign but I still get this error (I got it before the patch as well) when clicking on the link:
Fatal error: [] operator not supported for strings in /var/www/drupal/includes/common.inc on line 2319

This happens if I have freelinking set up for double brackets or single brackets. I think somehow the spaces are being converted the wrong way; in the URL spaces show up as %2B instead of %20. <--%2B is the HTML character code for the '+' sign.

You've got me on why the plus sign doesn't work, since it seems to work fine here on Drupal.org in the URL. The other option I see is wrapping the whole query string in quotation marks.

juampynr’s picture

juampynr commented
Status: Needs review » Needs work

Updating status. Seems that patch needs further work.

misc’s picture

misc commented
Status: Needs work » Reviewed & tested by the community

@mattbk, I can not reproduce your error. But as you says, you had the error before you applied the patch, so it should not be in this issue, it should be a separate one.

Patch works as intended, and removes the plus signs. Setting this as Reviewed and Tested by the community.

juampynr’s picture

juampynr commented
Title: Search link text has '+' in place of space » Search links text have '+' instead of spaces
Status: Reviewed & tested by the community » Fixed

Committed. Many thanks.

http://drupalcode.org/project/freelinking.git/commitdiff/9bdd0a5

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.