Download & Extend
Devel » Issues

Make krumo string output pre-formatted

Posted by salvis on August 28, 2011 at 8:18pm
Project:Devel
Version:8.x-1.x-dev
Component:devel
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Right now krumo's string output is wrapped (like HTML), i.e. multiple spaces and newlines are ignored. I see no benefit in removing this information, and I propose to add

white-space: pre;

to the div.krumo-preview style in order to preserve white space.

In fact, I think this is a bug, because if you need to see the text as it is in the variable, you can't...

Login or register to post comments

Comments

#1

Posted by salvis on August 28, 2011 at 8:21pm

Here's the patch.

The skin.css files all have CR/LFs, so the added line has the CR, too.

AttachmentSizeStatusTest resultOperations
devel.krumo_.preformatted.1262694.1.patch1.68 KBIdleFAILED: [[SimpleTest]]: [MySQL] Invalid patch format in devel.krumo_.preformatted.1262694.1.patch.View details

#2

Posted by salvis on August 30, 2011 at 11:13pm
Status:active» needs review

Anyone care to comment on this?

#3

Posted by System Message on August 30, 2011 at 11:14pm
Status:needs review» needs work

The last submitted patch, devel.krumo_.preformatted.1262694.1.patch, failed testing.

#4

Posted by salvis on August 31, 2011 at 12:48am

Ah, yes, the testbot doesn't like the line endings (see #1). Never mind...

#5

Posted by salvis on September 3, 2011 at 9:28am
Status:needs work» fixed

Committed to 8/7/6.

#6

Posted by System Message on September 17, 2011 at 9:31am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.