Closed (fixed)
Project:
Term Merge
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
29 Aug 2011 at 00:07 UTC
Updated:
21 Dec 2012 at 14:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gagarine commentedAnd the screen shoot:
Comment #2
safetypinThis is an excellent idea. I think it should be a tertiary link, next to the "Add term" link.
Comment #3
barrapontoJust change it to MENU LOCAL TASK.
Comment #4
barrapontoJust noticed it is asking for the wrong permission. Fixed it.
Comment #5
barrapontoJust noticed it is asking for the wrong permission. The patch fixes both lines.
Comment #6
barrapontoComment #7
brewthis commentedThe patch fixes the permissions error and moves the menu item into a tab for me. Thanks, however I'm still having a fatal ajax 500 error when trying to merge.
Comment #8
barraponto@oskarrough open another issue, unless you think it was caused by the patch.
Comment #9
brewthis commentedOf course, sorry - and it's not related to the patch.
Comment #10
gagarine commentedComment #11
nylin commentedPatch committed in the last dev version and upcoming beta-2, thank you very much and sorry for my inactivity!
Comment #12
nylin commentedComment #13
barrapontobut i didn't remove the button.
Comment #14
nylin commentedOkay, well I guess we only need the button in one place so I'll remove the initial button whenever I get the time.
Comment #15
bucefal91 commentedI personally think it's better to delete the button and keep only the tab. If no one is against, I will remove the button in the closest stable release.
Comment #16
barrapontoThat's what I was suggesting. I just didn't do it because I wanted my patch to be commited without lenghty discussions about removing the button.
Anyway, it's "Needs Work" until a patch is posted (then it moves to "Needs Review").
Comment #17
bucefal91 commentedHere comes a simple patch that removes the Merge Terms button on a vocabulary view page. Please take a look and approve, smb. Or if not, since the patch is quite straight forward, I will update myself the issue's status to Reviewed & tested in a few days.
Comment #18
bucefal91 commentedComment #19
s.daniel commentedWorks as described.
It would be nice to have this tab on the taxonomy/term/*/edit as well I think. Shell I open a new feature request for this?
Comment #20
bucefal91 commentedHere comes the next patch. It, besides removing the button, also adds the tab Merge Term on taxonomy/term/%taxonomy_term menu callback as requested by s.Daniel
As a usability improvement, if you click on Term Merge tab from a specific term, it will be selected as one of the "Terms to merge" select by default.
Comment #21
s.daniel commentedGreat! Applied patch term_merge.module cleanly.
The functionality works well. The only thing to note is that taxonomy/term/*/merge does not use the admin theme or overlay. Since this module will be mostly used by administrators and moderators thats not critical but I think it would be better to use the admin theme and work with the overlay. So its your choice whats up next. :)
Comment #22
bucefal91 commentedI didn't even know about how you can let Drupal know that it's an admin path and render it via overlay before your comment :)
I have added this "overlay support" and committed into 7.x-1.x-dev. Thanks for feedback!