The merge button look like a submit button and nothing tell than nothing going to append yet.

It will make sens to move it in the tab or as a link.

Comments

gagarine’s picture

StatusFileSize
new76.99 KB

And the screen shoot:

Screen shot 2011-08-29 at 2.04.43 AM.png

safetypin’s picture

Title: Use a tab or a link instead of a the "merge" button » Use a tab or a link instead of the "merge" button

This is an excellent idea. I think it should be a tertiary link, next to the "Add term" link.

barraponto’s picture

Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new0 bytes

Just change it to MENU LOCAL TASK.

barraponto’s picture

Just noticed it is asking for the wrong permission. Fixed it.

barraponto’s picture

Just noticed it is asking for the wrong permission. The patch fixes both lines.

barraponto’s picture

StatusFileSize
new808 bytes
brewthis’s picture

The patch fixes the permissions error and moves the menu item into a tab for me. Thanks, however I'm still having a fatal ajax 500 error when trying to merge.

An AJAX HTTP error occurred.

HTTP Result Code: 500 Debugging information follows. Path: /batch?id=2287&op=do StatusText: Service unavailable (with message) ResponseText: PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1: INSERT INTO {field_data_field_link} (entity_type, entity_id, revision_id, bundle, delta, language, field_link_url, field_link_title, field_link_attributes) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, ); Array ( [:db_insert_placeholder_0] => profile2 [:db_insert_placeholder_1] => 294 [:db_insert_placeholder_2] => 294 [:db_insert_placeholder_3] => profile [:db_insert_placeholder_4] => 0 [:db_insert_placeholder_5] => und [:db_insert_placeholder_6] => http://juliak.dk [:db_insert_placeholder_7] => ) in field_sql_storage_field_storage_write() (line 424 of /var/www/vhosts/example.com/httpdocs/modules/field/modules/field_sql_storage/field_sql_storage.module).
barraponto’s picture

@oskarrough open another issue, unless you think it was caused by the patch.

brewthis’s picture

Of course, sorry - and it's not related to the patch.

gagarine’s picture

Status: Needs review » Reviewed & tested by the community
nylin’s picture

Patch committed in the last dev version and upcoming beta-2, thank you very much and sorry for my inactivity!

nylin’s picture

Status: Reviewed & tested by the community » Closed (fixed)
barraponto’s picture

Status: Closed (fixed) » Needs work

but i didn't remove the button.

nylin’s picture

Okay, well I guess we only need the button in one place so I'll remove the initial button whenever I get the time.

bucefal91’s picture

Status: Needs work » Needs review

I personally think it's better to delete the button and keep only the tab. If no one is against, I will remove the button in the closest stable release.

barraponto’s picture

Status: Needs review » Needs work

That's what I was suggesting. I just didn't do it because I wanted my patch to be commited without lenghty discussions about removing the button.

Anyway, it's "Needs Work" until a patch is posted (then it moves to "Needs Review").

bucefal91’s picture

StatusFileSize
new1.29 KB

Here comes a simple patch that removes the Merge Terms button on a vocabulary view page. Please take a look and approve, smb. Or if not, since the patch is quite straight forward, I will update myself the issue's status to Reviewed & tested in a few days.

bucefal91’s picture

Status: Needs work » Needs review
s.daniel’s picture

Status: Needs review » Reviewed & tested by the community

Works as described.

It would be nice to have this tab on the taxonomy/term/*/edit as well I think. Shell I open a new feature request for this?

bucefal91’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new5.36 KB

Here comes the next patch. It, besides removing the button, also adds the tab Merge Term on taxonomy/term/%taxonomy_term menu callback as requested by s.Daniel

As a usability improvement, if you click on Term Merge tab from a specific term, it will be selected as one of the "Terms to merge" select by default.

s.daniel’s picture

Status: Needs review » Reviewed & tested by the community

Great! Applied patch term_merge.module cleanly.

The functionality works well. The only thing to note is that taxonomy/term/*/merge does not use the admin theme or overlay. Since this module will be mostly used by administrators and moderators thats not critical but I think it would be better to use the admin theme and work with the overlay. So its your choice whats up next. :)

bucefal91’s picture

Status: Reviewed & tested by the community » Fixed

I didn't even know about how you can let Drupal know that it's an admin path and render it via overlay before your comment :)
I have added this "overlay support" and committed into 7.x-1.x-dev. Thanks for feedback!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.