The permissions in singlesignon_perm() are duplicates from the node and system module. You should not declare them again.

/**
 * Implementation of hook_perm().
 *
 * Defines permission names for this module.
 */
function singlesignon_perm() {
  return array('access content', 'access administration pages');
}

Thanks for this module! I have implemented it for a big Swedish client and it's working very well.

CommentFileSizeAuthor
#2 singlesignon-DRUPAL-5.patch14.47 KBsun
#1 singlesignon-DRUPAL-5.patch709 bytessun

Comments

sun’s picture

Version: master » 5.x-1.x-dev
Category: bug » task
Status: Active » Needs review
StatusFileSize
new709 bytes

Indeed, that's bad practice.

sun’s picture

Title: Remove function singlesignon_perm() » Remove function singlesignon_perm() / code clean-up
StatusFileSize
new14.47 KB

Holy s.... actually, the whole coding style needs some love. See attached patch.

sun’s picture

*bump*

Due to these wrong permissions, the user permission 'access administration pages' is listed below singlesignon module in the access control table.

wayland76’s picture

Status: Needs review » Fixed

Committed to the DRUPAL-5 branch.

wayland76’s picture

See 1.1

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.