Posted by frjo on March 9, 2007 at 6:04pm
| Project: | Shared Sign-On |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The permissions in singlesignon_perm() are duplicates from the node and system module. You should not declare them again.
/**
* Implementation of hook_perm().
*
* Defines permission names for this module.
*/
function singlesignon_perm() {
return array('access content', 'access administration pages');
}Thanks for this module! I have implemented it for a big Swedish client and it's working very well.
Comments
#1
Indeed, that's bad practice.
#2
Holy s.... actually, the whole coding style needs some love. See attached patch.
#3
*bump*
Due to these wrong permissions, the user permission 'access administration pages' is listed below singlesignon module in the access control table.
#4
Committed to the DRUPAL-5 branch.
#5
See 1.1
#6
Automatically closed -- issue fixed for two weeks with no activity.