Should the Conditional Styles always show up in the code AFTER the active theme CSS? I'm trying to use this module with the Omega theme, and it seems as though my IE-specific styles are being rendered before the theme CSS, which in effect, seems to make them useless. I'm just trying to track down where this can be fixed, through this module or through Omega. In other themes, it seems to be rendering the right order, so it makes me think it's a theme-specific issue.

CommentFileSizeAuthor
#2 conditional_styles-fix_for_omega_theme-1263760-2.patch726 byteshkirsman

Comments

minneapolisdan’s picture

minneapolisdan commented
Status: Active » Closed (works as designed)

I figured this out, it's just that this module shouldn't be used with the Omega theme. See this post for more info, http://drupal.org/node/1263750

hkirsman’s picture

hkirsman commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Closed (works as designed) » Needs review
StatusFileSize
new conditional_styles-fix_for_omega_theme-1263760-2.patch726 bytes

IMO this module should work with Omega.

I think we should set more weight so it would work with all themes.

I've set group and weight to 9999 so the files would load after all the other stylesheets in Omega theme. I understand that grouping is ment for aggregation but for this module every stylesheet is packed separately anyways so it doesn't harm the download speeds for user.

Lower group and weight numbers work too but 9999 is more safer. It could be 99999 or 999999 too I guess.

I've attached a patch. What you think?

kclarkson’s picture

kclarkson commented
Title: Placement of Conditional Styles in Code: Fix for Omega » Placement of Conditional Styles in Code: fix door Omega

I found this issue after hours of trying to add the conditional styles to my .info file.

I have applied the patch and so far everything looks good.

kclarkson’s picture

kclarkson commented
Title: Placement of Conditional Styles in Code » Placement of Conditional Styles in Code: fix for Omega
kclarkson’s picture

kclarkson commented
Title: Placement of Conditional Styles in Code: fix for Omega » Placement of Conditional Styles in Code: Fix for Omega

Typo

astonvictor’s picture

astonvictor commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

I'm closing it because the issue was created a long time ago without any further steps.

if you still need it then raise a new one.
thanks