Newer Versions of ffmpeg won't use padleft, padright and so on anymore. Using the padding will cause this message:

Option 'padleft' has been removed, use the pad filter instead
ffmpeg: failed to set value '0' for option 'padleft'

So the newer versions of ffmpeg uses this instead: -vf pad=0:0:0:0:black

see: #1119550: ffmpeg padding doesn't work, use -vf pad instead

This is a good moment to remove ffmpeg_converter_get_padded_size() and use only ffmpeg_wrapper_padded_size(), to only fix the problem in one place.

Comments

osopolar’s picture

zoo33’s picture

Sounds good.

Does FFmpeg Wrapper handle both the old and the new format? If not, we should at least document which versions of FFmpeg that can be used.

Did you test the patch yourself?

osopolar’s picture

I added a setting to ffmpeg_wrapper for that, so you can choose between the two implementations manually. There is no auto detection. I am not happy with that, because it's hard to guess which option to choose. On the other hand, using ffmpeg needs some knowledge, so you can find out. I guess I should add a description to the select box.

osopolar’s picture

Issue summary: View changes

clean up