This isn't so much a feature request as just me offering up a field handler for anyone using the Metatags Quick module in 7.x. I went with it since Nodewords is being rewritten but isn't ready, and it seemed to be a pretty popular alternative. The code is available on my blog if anyone wants to use it. I hope it helps someone!

http://openmonkey.blogspot.com/2011/08/migrate-module-and-important-seo-...

CommentFileSizeAuthor
#6 metatags_quick_field_handler-1264506-6.patch1.16 KBreujwils
#2 metatags_quick_field_handler-1264506.patch807 bytesreujwils

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Postponed (maintainer needs more info)

The best way to "offer up a field handler" is to submit a patch.

reujwils’s picture

reujwils commented
StatusFileSize
new metatags_quick_field_handler-1264506.patch807 bytes

Sure thing Mike, sorry about that. I'm quite new to this, so I'll still learning the ropes :) Thanks!

reujwils’s picture

reujwils commented
Status: Postponed (maintainer needs more info) » Active

Forgot to update the status after I supplied a patch.

drewish’s picture

drewish commented
Status: Active » Needs review

If it's got a patch that you think should work this is the correct status.

drewish’s picture

drewish commented
Status: Needs review » Needs work

I'd add a little argument handling code even though you don't really use them, just to be safe:

    $arguments = isset($values['arguments']) ? $values['arguments'] : array();
    unset($values['arguments']);

Otherwise if someone (incorrectly in this case) passes in arguments it'd end up sticking an empty row into your values.

reujwils’s picture

reujwils commented
Status: Needs work » Needs review
StatusFileSize
new metatags_quick_field_handler-1264506-6.patch1.16 KB

Thanks drewish for the feedback. I went ahead and updated the patch with your recommendations.

Let me know if there is anything else that I would need to modify!

drewish’s picture

drewish commented

Looks good to me, I'll let mikeryan weigh in on it.

drewish’s picture

drewish commented

So #1321062: Create a simple base class for field handlers got committed so this should be doable in about 3 lines now ;)

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work

Yes, let's simplify this.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Closed (duplicate)

It's been done directly in metatags_quick: #1408542: Add support for migrate.