Posted by Sutharsan on August 31, 2011 at 9:19am
1 follower
Jump to:
| Project: | LoginToboggan |
| Version: | 7.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
By changing the name of front-end *.css into *.theme.css themers can disable all front-end css in hook_css_alter() in their theme. CSS required for js is separated out into *.base.css. Drupal core already uses this naming scheme.
Although I don't like the fact that the css files are loaded with each page, I left this for a separate issue.
| Attachment | Size |
|---|---|
| loggintoboggan-css-files.patch | 3.04 KB |
Comments
#1
system module is the only core module i see that uses the scheme you're referring to. i've never heard of this approach, but i'm also not a themer.
why are these in both the .base.css and .theme.css files?
+.toboggan-unified.login #register-form {+ display: none;
+}
+
+.toboggan-unified.register #login-form {
+ display: none;
seems redundant.
#2
The approach is promoted by mortendk (see his session in London) and allows for themers to easily recognize and disable the Theme related template files which avoids endless overriding of css (which adds css, is bad for css maintenance and clutters the total css picture).
*.base.css: CSS required for proper function of the module, like the above 'display: none'.
*.admin.css: CSS for the module's admin pages.
*.theme.css: CSS for front-end theme.
The two display none's are an oversight and should only be in base.css
#3
won't this change break any CSS overrides that people have done on the module's CSS in their current release of the module?
k, so needs work.