Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Because of #978944: Handle exceptions thrown in cron Drupal 7.8 added the following info file:
name = "Common Test Cron Helper"
description = "Helper module for CronRunTestCase::testCronExceptions()."
package = Testing
version = VERSION
core = 7.x
hidden = TRUE
When processing an info file, each of those values is run through:
// Handle PHP constants
if (defined($value)) {
$value = constant($value);
}
Which on PHP 5.2 has the amusing side effect of trying to load the Helper module for CronRunTestCase
class to get the testCronExceptions
constant. Clearly this fails.
The fix for this is simple, and is already in core, we just need to re-steal the code from drupal_parse_info_format
into _provision_drupal_parse_info_file
.
I'm happy to do that asap.
Does this warrant a 1.4 release?
Comments
Comment #1
Steven Jones CreditAttribution: Steven Jones commentedNote that this presents itself as the following error:
When verifying a platform.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedIt has been reported once already today in IRC.
I agree we ought to release a hotfix for this. We've done so in the past, and D7 is only getting more and more popular (if it broke D5, maybe we could sit on it for a bit while we accumulate other fixes).
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedFix pushed into all branches, let's see what Jenkins thinks.
Comment #4
omega8cc CreditAttribution: omega8cc commentedThe fix works for D 7.8 and PHP 5.2.17.
I mean http://drupalcode.org/project/provision.git/commit/1d0ff08
Comment #5
Steven Jones CreditAttribution: Steven Jones commentedComment #6
nicksanta CreditAttribution: nicksanta commentedI pulled the fix from #4 and I'm now able to provision a D7.8 platform.
Comment #7
nicksanta CreditAttribution: nicksanta commentedFixing status
Comment #8
Macronomicus CreditAttribution: Macronomicus commentedAfter using #4 I was able to verify my Pressflow 7 (d-7.8) platform!
Cheers!
Comment #10
kepford CreditAttribution: kepford commentedI can also confirm that this #4 works.
Comment #11
lunk rat CreditAttribution: lunk rat commentedJust want to spell out the process for those newbs on git/aegir (like me, thanks again for help on irc @joestewart and @algar)
cd into your provision directory:
cd /usr/share/drush/commands/provision
download packages_7.inc
wget http://drupalcode.org/project/provision.git/blobdiff_plain/63e05e9e6a5b779013206e243189f11289016db2..1d0ff08:/platform/drupal/packages_7.inc
rename the file to "patch"
mv packages_7.inc patch
finally apply with git:
git apply patch
Hope this helps someone verify D7.8 + on Aegir
Comment #12
wik CreditAttribution: wik commented@lunk_rat, there is simplest way, you can always download plain file at certain commit point, i.e.:
http://drupalcode.org/project/provision.git/blob_plain/1d0ff08:/platform...
unless you really need to patch it for any reason :)