Because of #978944: Handle exceptions thrown in cron Drupal 7.8 added the following info file:

name = "Common Test Cron Helper"
description = "Helper module for CronRunTestCase::testCronExceptions()."
package = Testing
version = VERSION
core = 7.x
hidden = TRUE

When processing an info file, each of those values is run through:

// Handle PHP constants
if (defined($value)) {
  $value = constant($value);
}

Which on PHP 5.2 has the amusing side effect of trying to load the Helper module for CronRunTestCase class to get the testCronExceptions constant. Clearly this fails.

The fix for this is simple, and is already in core, we just need to re-steal the code from drupal_parse_info_format into _provision_drupal_parse_info_file.

I'm happy to do that asap.

Does this warrant a 1.4 release?

Comments

steven jones’s picture

steven jones commented

Note that this presents itself as the following error:

Drush command terminated abnormally due to an unrecoverable error. Error: Class 'Helper module for CronRunTestCase' not found in /var/aegir/.drush/provision/platform/drupal/packages_7.inc, line 97

Output from failed command : Fatal error: Class 'Helper module for CronRunTestCase' not found in /var/aegir/.drush/provision/platform/drupal/packages_7.inc on line 97

When verifying a platform.

Anonymous’s picture

Anonymous (not verified) commented

It has been reported once already today in IRC.

I agree we ought to release a hotfix for this. We've done so in the past, and D7 is only getting more and more popular (if it broke D5, maybe we could sit on it for a bit while we accumulate other fixes).

steven jones’s picture

steven jones commented

Fix pushed into all branches, let's see what Jenkins thinks.

omega8cc’s picture

omega8cc commented
Status: Active » Reviewed & tested by the community

The fix works for D 7.8 and PHP 5.2.17.

I mean http://drupalcode.org/project/provision.git/commit/1d0ff08

steven jones’s picture

steven jones commented
Status: Reviewed & tested by the community » Fixed
nicksanta’s picture

nicksanta commented
Status: Fixed » Reviewed & tested by the community

I pulled the fix from #4 and I'm now able to provision a D7.8 platform.

nicksanta’s picture

nicksanta commented
Status: Reviewed & tested by the community » Fixed

Fixing status

Macronomicus’s picture

Macronomicus commented

After using #4 I was able to verify my Pressflow 7 (d-7.8) platform!

Cheers!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kepford’s picture

kepford commented

I can also confirm that this #4 works.

lunk rat’s picture

lunk rat commented

Just want to spell out the process for those newbs on git/aegir (like me, thanks again for help on irc @joestewart and @algar)

cd into your provision directory:
cd /usr/share/drush/commands/provision
download packages_7.inc
wget http://drupalcode.org/project/provision.git/blobdiff_plain/63e05e9e6a5b779013206e243189f11289016db2..1d0ff08:/platform/drupal/packages_7.inc
rename the file to "patch"
mv packages_7.inc patch
finally apply with git:
git apply patch

Hope this helps someone verify D7.8 + on Aegir

wik’s picture

wik commented

@lunk_rat, there is simplest way, you can always download plain file at certain commit point, i.e.:

http://drupalcode.org/project/provision.git/blob_plain/1d0ff08:/platform...

unless you really need to patch it for any reason :)

  • Commit 1d0ff08 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by Steven Jones: 
    Issue #1266484 - Cannot verify Drupal 7.8 with PHP 5.2
  • Commit af8cf6e on 6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by Steven Jones:
    Issue #1266484 - Cannot verify Drupal 7.8 with PHP 5.2