How do I edit a table's authoring information?

Hiya, yep you're on the right track - weirdly you also have to tell the filter function to show the admin links as well (complete overkill, but it's functionality requested by someone else hence how comes I implemented it this way). Just change your call to;

[tablemanager:1,NULL,TRUE] (the TRUE is to enable the links)

Thanks

Pobster

...If you've enabled the table view menu item then there's a setting in the erm, "settings" ;o) to enable links in the tables.

Pobster

Hmmm... I really should have read your post the whole way through properly before I answered ;o)

Well... It sounds like it should be working? If you've enabled the 'view tables' menu item and set the settings to 'show links' then users with the correct permissions should be seeing create/ edit/ delete links? You know there's a distinct possibly that part is broken in the upgrade to 5.0 - give me a while to test what's happening...

Thanks

Pobster

Oh yeah, I forgot about this! Its because for some unfathomable reason Drupal 5.0 sticks <em> tags around the access control table names. Check it out, it reads "create table content" instead of simply "create table content" like it did in the 4.7 version. I've NO idea why... To perhaps get it working (in a hackish way) you could try changing this function;

/**
 * Returns the user entered name for a table.
 */
function tablemanager_fetchname($tid) {
  $result = db_fetch_object(db_query('SELECT tm.name
                                      FROM {tablemanager} tm
                                      WHERE tm.tid = %d',
                                      $tid)
  );
  return $result->name;  // change this line to - return "<em>".$result->name."</em>";
} // tablemanager_fetchname

This may or may not work I'm afraid... I've been a bit too busy to look into what's going on, sorry...

Pobster

Ah ignore that above, use this instead and PLEASE report back if it solves your problem or not;

/**
 * Implementation of hook_perm
 */
function tablemanager_perm() {
  $perms = array('administer tables', 'list tables', 'administer/ create own tables');
  foreach (tablemanager_tables() as $table) {
    $perms[] = t("create @table content", array('@table' => $table['name']));
    $perms[] = t("edit any @table content", array('@table' => $table['name']));
    $perms[] = t("edit own @table content", array('@table' => $table['name']));
  }
  return $perms;
} // tablemanager_perm

All you need to do is change the six '%' symbols into '@' symbols...

Thanks

Pobster

There are no rules here so as long as I get the message then it's fine ;o)

I'm not 100% sure what you mean though? Could you go through exactly what all your tablemanger settings are, and what works and what doesn't? TBH that part of the code has *never* been tested by myself as it's not something I use... I've always had my doubts about how well it works! ;o)

Pobster

Hmmmm... That is strange... Well this is the code that decides whether to display the links or not;

      if ($links) {
        if ($user->uid == $result->tableuid && user_access('administer/ create own tables') || user_access("edit own ".tablemanager_fetchname($tid)." content") || user_access("edit any ".tablemanager_fetchname($tid)." content") || user_access('administer tables')) {
          if (in_array($user->uid, $uid) || user_access("edit any ".tablemanager_fetchname($tid)." content") || user_access('administer tables') || user_access('administer/ create own tables')) {
            array_push($header, array('data' => t('Operations'), 'colspan' => '2'));
            $flag = TRUE;
          }
        }
      }

I'd suggest perhaps changing it to;

      if ($links) {
        if ($user->uid == $result->tableuid && user_access('administer/ create own tables') || user_access("edit own ".tablemanager_fetchname($tid)." content") || user_access("edit any ".tablemanager_fetchname($tid)." content") || user_access('administer tables')) {
          if (in_array($user->uid, $uid) || user_access("edit any ".tablemanager_fetchname($tid)." content") || user_access("edit own ".tablemanager_fetchname($tid)." content") || user_access('administer tables') || user_access('administer/ create own tables')) {
            array_push($header, array('data' => t('Operations'), 'colspan' => '2'));
            $flag = TRUE;
          }
        }
      }

Let me know if that works? It's all very confusing in that area... I'm sure there's probably a better way to go about doing it...

Thanks

Pobster

Okay! Turn it back to what it was before, what you need to do is simply add this;

|| user_access("edit own ".tablemanager_fetchname($tid)." content") into the second load of queries.

I think I just missed it before?

Pobster

So this;

if (in_array($user->uid, $uid) || user_access("edit any ".tablemanager_fetchname($tid)." content") || user_access('administer tables') || user_access('administer/ create own tables')) {

becomes;

if (in_array($user->uid, $uid) || user_access("edit own ".tablemanager_fetchname($tid)." content") || user_access("edit any ".tablemanager_fetchname($tid)." content") || user_access('administer tables') || user_access('administer/ create own tables')) {

Pobster

It's automatic - the users uid gets attached to tablemanager_data - check it out in phpmyadmin or something? You know... I'm sure that part of it worked okay as I remember someone else using it??? (That's before that change above) Are you sure you're using it correctly? Obviously you can only view the admin links if you've got an entry with your own uid attached to it.

...This could of course be something else which got broken in the update to 5.0?

Pobster

And does the uid column reflect that a user *has* entered a row? Like I said, the links shouldn't show unless there is *something* there to administrate?

Pobster

I think you misunderstand, you've got two entries for that table - take a look at tablemanager_data and see if the 'uid' column for those two entries matches the uid of the user you're granting permissions to.

Pobster

Okay... I've gone through the trouble of installing the module on a Drupal 5.0 test site and it works without changing anything.

I think perhaps you're not getting what the permission actually do;

create test content - allows a user to create rows in a table called 'test'
edit any test content - 'semi-administration' allows a user to edit *any* row in table 'test'
edit own test content - IF a user has created a row (to be used together with the 'create test content' permission above) then allow them to edit it. If they've nothing to be able to edit, then no admin links are displayed!

I hope this is just a misunderstanding of use! As I'm very confused!

Pobster

Do you have phpmyadmin installed? Or do you have shell access?

Pobster

It's perfectly safe for you to use phpmyadmin to edit the uids (you can edit a group of them together that way as well!)

Absolutely no worries - happy to help. If anything you've done me a favour by pointing out that this area isn't clear and needs work! :o) Seeing as there's a complete rewrite coming - this is very helpful!

Thanks

Pobster