Closed (fixed)
Project:
Ubercart
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Sep 2011 at 13:16 UTC
Updated:
17 Sep 2011 at 17:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
bwynants commenteduc_googleanalytics_uc_order hook checks for
if ($op == 'new' && arg(0) == 'cart') {
however on the 'new' call this is what the 'args' contains
[01-Sep-2011 18:47:59] Array
[01-Sep-2011 18:47:59] (
[01-Sep-2011 18:47:59] [0] => system
[01-Sep-2011 18:47:59] [1] => ajax
[01-Sep-2011 18:47:59] )
so there is nothing something in the session and uc_googleanalytics_page_alter fails to ad the script...
Comment #2
Island Usurper commentedOh, that's an unfortunate side effect of adding the Drupal-style AJAX to the checkout page.
The check for 'cart' in the URL is there to keep from setting the analytics JS for orders created by the administrator in the backend. However, it might not be necessary since that hook only sets a session variable that isn't used until the checkout complete page is viewed. If an admin goes through checkout, he should get the new order in the session, and not whatever order he had created earlier.
Comment #3
bwynants commentedExactly the same fix as what I did on my server. Thanks!
Comment #4
longwaveCommitted.