Required fields not consistent between time entry form on case node and on user time sheet [#1266746]

The time entry forms on the user time sheet and on the case node have the same fields, but not the same requirements.

HOURS: not required on case node -- required on time sheet
NOTE: not required on case node -- required on time sheet

Also, it is possible to submit time entries on case nodes without any fields filled in. This does not make sense.

I suggest the forms be made identical in this respect, with the following field requirements on both forms:

USER: Required
ACTIVITY: Optional
DATE: Required
HOURS: Required
NOTE: Optional

For ACTIVITY and NOTE, it would be nice if you could set it to be required through the case tracker settings.

Comments

Comment #1

drclaw commented 13 September 2011 at 00:00

Yeah, the time sheet's taken a bit of a back seat to other things lately. We'll take a look at that ASAP. Thanks.

Comment #2

codi commented 11 March 2012 at 01:08

Assigned:	Unassigned	» codi
Status:	Active	» Needs work

For the node and comment time tracking, we can't force field requirements because the time tracking is attached to an already existing form which should be able to submit without time entry data.

For the time sheet I think the required fields are appropriate when creating a time entry for a comment. What I would like to see however is if a node itself can have time entries attributed to it, and the user has selected 'node' for the 'track time on' select list then the comment field should switch to a 'notes' field and not be required.

Not sure if I can get this done this weekend, but hopefully sometime next week.

Comment #3

drclaw commented 14 March 2012 at 04:59

@codi Yeah, having that done for Mmmmmonday would be greeeat. Can you just put the module on my desk by 10:00am?

Comment #4

drclaw commented 11 May 2012 at 23:03

What about if time logging on nodes had the duration / time interval fields required? it doesn't make sense to allow for just notes to be posted to a node through time tracker because it's not really a "note" logging system. That's what comments are for...?