Add [term:parents] and [menu-link:parents] array tokens

+1 and subscribing

subscribing

subscribe

subscribe

subscribe

sub. Patch failed on latest dev release, only the info file though.

Tested [node:menu-link:parents:join:?] not too sure where the "join" character is meant to go (I assume it should replace the question mark? If so, it didn't work for me.

Ah I got it [node:menu-link:parents:join:/] gave me an imploded url of parent menu items. I had to change punctuation settings to not remove slashes though, this means that slashes in node titles wouldn't be removed though but this should be fine.

patch in #4 applies cleanly to latest 7.x-1.x, taxonomy parents token works great, thanks much!

subscribe

On what version do you apply the patch? Tried it on beta6 and dev release but both give errors. Tokens are available, but as soon as I bulk update my aliases, I get errors (deleted aliases first).

Please apply #4 to your token module, then take this patch to patch the "token.tokens.inc", continue with #10 after that.

Please ignore #14

Please apply #4 to your token module, then take this patch to patch the "token.tokens.inc", continue with #10 after that. This is the correct patch.

@sense-design I tried the patch from #15, but when I tried apply it I got:

> git apply 1266928-parents-array_0.patch.1
1266928-parents-array_0.patch.1:34: trailing whitespace.
1266928-parents-array_0.patch.1:49: trailing whitespace.
1266928-parents-array_0.patch.1:79: trailing whitespace.
error: token.tokens.inc Locally Modified (Based On LOCAL): No such file or directory

So I applied the patch manually. Now when I look at diff I see the only change:

@@ -414,6 +413,11 @@ function token_tokens($type, $tokens, array $data = array(), array $options = ar
           $type_name = node_type_get_name($node);
           $replacements[$original] = $sanitize ? check_plain($type_name) : $type_name;
           break;
+        case 'parents':
+          if ($parents = token_taxonomy_term_load_all_parents($term->tid)) {
+            $replacements[$original] = token_render_array($parents, $options);
+          }
+          break;
       }
     }

The other hunks from your patch #15 seems to be included in the previous patch #4 by Dave Reid. Is it correct? Or am I missed/overlooked something?

Anyway menu parents token seems to be working as expected.

Here is a re-roll of #4

This is #15 rerolled and it seems wojtha is right about the only change. @sense-design can you explain why you added that piece?

Per davereid in irc the token.inc portion shouldn't be there.
#3 is #17 patch without token.inc
#4 is #18 patch without token.inc

Looks like it passed. So 1266928-d7-3.patch should be the correct patch to use. Anyone care to RTBC?

I'm having a difficult time trying to figure out the tests. Any chance of getting an example of the taxonomy parents test and then I can maybe figure out the menu one from there?

I just tried this out, parents token showed up in replacement patterns with no problems, but trying to generate aliases I got:

Fatal error: Class 'MenuTokenObject' not found in C:\xampp\htdocs\website\sites\all\modules\token\token.module on line 936

This is using the beta 7 release, should I be using the dev version?

Edit: Tried the dev release:

Fatal error: Class 'MenuTokenObject' not found in C:\xampp\htdocs\website\sites\all\modules\token\token.module on line 936

Line 936 is $cache[$mlid] = array($plid => new MenuTokenObject($parent)) + $cache[$mlid];

I tried both patch d7-3 and d7-4 and get the same error with both.

It seems the token.inc file that was removed from this patch contained the MenuTokenObject class. @davereid is there another patch somewhere that needs to get pushed forward so token.inc can be added?

Sorry I didn't get to it in time. Thanks for committing quickly.

Hi,

this is quite good, but doesn't mimic completely the behavior of termpath token seen on D6. Especially, there's no more "/" separator between terms, and this "/" is replaced by a "-" : is there a way to avoid this?

I mean, on D6 you were able to mix "-" (in the term) and "/" (between terms).