CardPay

Please read and follow http://drupal.org/coding-standards.

Specifically, remove the tabs, remove whitespace at the end of lines, whitespace on blank lines, and whitespace and at the end of your .module file. You can install the Coder module and it will help you find some of these problems, but the Coder module doesn't find everything.

Remove the $Id$ and the version = "6.x-1.0" from your .info file. Remove the $Id$ from your .install file.

Your module requires mcrypt, which is not installed with PHP by default, so you must check on the presence of mcrypt in hook_requirements(). Also, please include instructions in a README.txt for installing mcrypt and any other non-standard extensions that you need.

"Implementation of" should be "Implements" in all your hook comments.

I haven't looked at the code for security problems - I'll do that after it gets cleaned up.

In uc_cardpay_uninstall -
1. Ideally you should use variable_del on specific variable names to prevent accidentally deleting something.
2. If you don't use variable_del then you will need to clear the cache because your delete statement isn't doing that.

It would be relatively easy for a user to spoof this:
$_SESSION['pay_method'] = $_POST['pay_method'];

Is the pay_method not available in $arg1 or $op or something?

Instead of using ! and check_plain you can simply use the @ placeholder in this code:

'... !reference.', array('!reference' => check_plain($VS))

The ideal way to do this allows translators to change what text is linked:

      $output = t('Payment failed') . '<br /><a href="' . $s_front . '">' . t('Click to return to the front page.') . '</a>';

should be:

      $output = t('Payment failed <br /><a href="!front_url">Click to return to the front page.</a>', array('!front_url' => url());

In uc_cardpay_complete, it seems like you are only checking the checksum if it's an "OK" value. Is it possible in the API to confirm the checksum for all result codes? If so I suggest doing that to ensure the module can rely on the incoming data before doing anything else with it.

Regarding making the machine name uc_cardpay, you will need to push to a new directory in git with the name uc_cardpay. The current one is just cardpay which is an issue.

Regarding why this process takes so long...there are many reasons. One of the reasons your application is harder to review is that it's about Ubercart so only people who are familiar with Ubercart are able to give a review.

Also, I noticed several relatively small coding standards issues. I suggest using the coder module on "minor."

tagging and setting status appropriately.

Also, thanks for your work to contribute a module - this seems like it will be a great addition!

The application has been marked for need work in 15 weeks, and there is no email address available for the applicant. Marks this as closed (won't fix). @petiar, if this is wrong, please feel free to reopen this application.