Closed (fixed)
Project:
Context
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Sep 2011 at 04:37 UTC
Updated:
5 Mar 2012 at 13:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
drasgardian commentedhere's the patch file
Comment #2
mathieuhelie commentedThanks for the fix. I'm building a single-language site (non-English) and was running into the same problem.
Comment #3
Anonymous (not verified) commentedThanks for the fix. It's working and solved my problems on that bug.
Comment #4
k4v commentedI just came across the same bug and fixed it, before i found this =).
i used field_get_items() instead -- which is the best way to do it?
Comment #5
romsP commented#4 works well for me.
Comment #6
Anonymous (not verified) commented#4 works well for me too !
Comment #7
antoniomanco commentedHello.
A question. I need replace all code in context_condition_node_taxonomy.inc with the patch? or Add the patch to existing code? thanks
Comment #8
bojanz commented@antoniomanco
See http://drupal.org/patch/apply
field_get_items() is cleaner. Seems like this is the only case of incorrect field language usage in context.
#4 wasn't rolled correctly. Attaching a reroll and marking RTBC.
Comment #9
kelvinleehk commentedI can't seem to apply this this patch. Git apply -v simply returns no result / error / nothing and the file was not patched whatsoever. I downloaded the file to sites/all/modules/context and git apply it from there. The patch in #4 worked fine though.
Comment #10
bojanz commentedpatch -p1.
Comment #11
kelvinleehk commentedTried as some suggested that git apply does not work from within the local checkout of an unrelated git repository. Didn't work as I hoped.
FYI I'm running Git 1.7.6.
Comment #12
Anonymous (not verified) commentedI just tried for 2 long hours to figure this out somehow until I ended up here and OMG the patch already exists! Thank you :-)
patch from #8 works perfectly here.
Comment #13
bojanz commentedGreat, thanks for testing.
Comment #14
skwashd commentedThis could be easier to read. I propose doing it like so:
I personally really dislike if assignment statements.
Comment #15
brenk28 commentedThis is a version of the above patch from #8 to use in a make file.
Comment #16
DrJochum commentedPatch form #8 did not work for me.
But the original one from #1 was fine!
I am using dupal 7.10
Comment #17
tekante commentedCommitted to 7.x-3.x with commit f5966dc5e3aea325802ea41e6ca26ba9ad90d2c0, will be available in next dev build. Thanks for the bug report and to those helping to roll a patch.
Comment #19
rafinskipg commentedPatch in #4 worked, but it wasn't prepared for git patcher... I had to modify it.