Can you make the line for the signature only appear if there is a signature? Thanks

CommentFileSizeAuthor
#6 signature_1.patch524 bytesJomel
#2 signature_0.patch623 bytesairblaster
#1 signature.patch623 bytesairblaster

Comments

airblaster’s picture

airblaster commented
Title: The line » Don't show seperator if signature is empty & use check_markup with $check=false
Status: Active » Needs review
StatusFileSize
new signature.patch623 bytes

Here is a patch to fix this.
Also changes the use of check_markup according to http://api.drupal.org/api/5/function/check_markup (hope I interpreted this correctly).

airblaster’s picture

airblaster commented
StatusFileSize
new signature_0.patch623 bytes

Here is a patch to fix this.
Also changes the use of check_markup according to http://api.drupal.org/api/5/function/check_markup (hope I interpreted this correctly).

airblaster’s picture

airblaster commented

Sorry for the double post.
Another way to do this might be introducing a new variable in the settings.
In case anyone needs the seperator to show even if the signature is empty.

hanief84’s picture

hanief84 commented
Title: Don't show seperator if signature is empty & use check_markup with $check=false » Patch? How to?

Sorry, coz I'm not a programmer. Anyway, how to apply the patch? Any tutorial?

My website:- http://www.indiecom.net

ultraBoy’s picture

ultraBoy commented
Title: Patch? How to? » Don't show seperator if signature is empty & use check_markup with $check=false

Please don't use senseless titles. You don't have permissions for commiting patches. I'll review your patch in a couple of days, thanx for the issue.

Jomel’s picture

Jomel commented
StatusFileSize
new signature_1.patch524 bytes

AFAIK we ought to at least return an empty string if its empty, it seems odd for a function to only sometimes return things...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
Status: Needs review » Closed (works as designed)

Closing out all 6 year old issues at this point.