Start over packages without the administer localization server permission

Thanks for working on this! Quick feedback:

- !empty($arg[4]) should go before is_numeric() to avoid notices
- l10n_communinty_project_releases_table() adds a column at all times to the table but only adds a header to it if start_over is supposed to be there; the column is there anyway; let's not add the column!
- These messages are pretty pointless for the users targeted, because they cannot do these things: "If you clean up the database before this release is parsed again, source strings and translations will be lost. Always make database backups.", "Make sure to parse this release data again before deleting a project or cleaning up the database, or you will loose existing translation data.".
- Whether the release to be deleted belongs to the project linked is not checked; if I click a truncated link I can easily accidentally reset a release I did not want to; at least check if the release belongs to the project in question

Patch tested and works well.

+++ l10n_server/l10n_community/pages.inc	2011-09-02 11:05:33.000000000 +0200
@@ -415,33 +415,93 @@
+function l10n_communinty_project_releases_table($releases, $project_uri, $project_name, $link_releases = TRUE, $start_over = FALSE) {

Where is this invoked with $start_over FALSE?

+++ l10n_server/l10n_community/pages.inc	2011-09-02 11:05:33.000000000 +0200
@@ -415,33 +415,93 @@
+    if ($start_over) {
+      $rows[] = array(
+        $link_releases ? l($release_title, 'translate/projects/' . $project_uri . '/releases/' . $release->rid) : $release_title,
+        empty($release->download_link) ? t('n/a') : l(basename($release->download_link), $release->download_link),
+        format_date($release->file_date),
+        empty($release->last_parsed) ? t('in queue') : format_date($release->last_parsed),
+        $file_count,
+        $release->sid_count,
+        $error_count ? l($error_count, 'translate/projects/' . $project_uri . '/releases/' . $release->rid, array('fragment' => 'source-warnings')) : $error_count,
+        l(t('Start over'), 'translate/projects/' . $project_uri . '/releases/reset/' . $release->rid),
+      );
+    }
+    else {
+      $rows[] = array(
+        $link_releases ? l($release_title, 'translate/projects/' . $project_uri . '/releases/' . $release->rid) : $release_title,
+        empty($release->download_link) ? t('n/a') : l(basename($release->download_link), $release->download_link),
+        format_date($release->file_date),
+        empty($release->last_parsed) ? t('in queue') : format_date($release->last_parsed),
+        $file_count,
+        $release->sid_count,
+        $error_count ? l($error_count, 'translate/projects/' . $project_uri . '/releases/' . $release->rid, array('fragment' => 'source-warnings')) : $error_count,
+      );
...
+  $project = l10n_server_get_projects(array('uri' => $form_state['values']['project']->uri));
+  $releases = l10n_server_get_releases($form_state['values']['project']->uri, FALSE);
+  $release = $releases[$form_state['values']['release']->rid];
+
+  if (is_object($project) && is_object($release) && $project->pid == $release->pid) {

The only difference in these two arrays is the last item. Let's not duplicate code! Instead build-up a $row and tack on the last item when available. Then add to $rows.

+  $project = l10n_server_get_projects(array('uri' => $form_state['values']['project']->uri));
+  $releases = l10n_server_get_releases($form_state['values']['project']->uri, FALSE);
+  $release = $releases[$form_state['values']['release']->rid];
+
+  if (is_object($project) && is_object($release) && $project->pid == $release->pid) {

Well, checking if $project->pid == $release->pid at this point looks like futile, since $release can only come from a list of releases from the project. Looks like we should check whether $releases[$form_state['values']['release']->rid] even exists, right? Same in l10n_communinty_projects_release_reset(). I can invoke that function with a URL of unrelated project/release info, and could get through.

Works well. :)

Committed to 6.x-3.x. Needs to be ported to 7.x-1.x

Also rolled out to localize.drupal.org.

Announced at http://localize.drupal.org/node/4124

Missing for me too. I assume I should have seen it on pages like http://localize.drupal.org/translate/projects/avitamin/releases or http://localize.drupal.org/translate/projects/avitamin/releases/46629 , right?

I've granted that permission when I rolled this out. This is how the permission matrix for our roles look like for the server: https://skitch.com/gabor.hojtsy/gy5qt/permissions-localize.drupal.org - the other granted permissions work. The og_user_roles module we have just inherits those settings for in-group permissions. I've also cleared the cache. Did that help any? (I can see those links: https://skitch.com/gabor.hojtsy/gy5xx/localized-drupal-distribution-rele... - although I'm clearly an admin here, that at least proves the update is rolled out proper).

All right, well, the group specific roles kick in when you *are* under a group. Looking at this, when you view this page it is not under any language group, so it will not grant you any permissions for that. Since you can be a member of any number of groups, possibly your permission for this would be the highest of your permissions from all the groups. That does sound like kind of overkill for this though and a pretty bad precedent... Looks like we need to figure out a way to have this UI somehow under a language group to keep the self-service nature of permission granting (vs. global permissions) and still have this feature work.

updated: I tested the patch and not works well.

start over permission problems

I tested the patch and very works well. :)

This would widen the administer comments, administer nodes, etc. permissions these people have to the whole site, which is a no-go. The permissions of team managers should be confined to the group. As I've said above, this feature should be put under a group instead.

I don't think its easier to explain what that would be to 100 always rotating language teams admins.... This is a huge crowd changing organically. Making the UI intuitive and in-place is best.

Eg, I imagine you realize the strings are missing on the filter UI. So we can put on a little "troubleshooter" link there, like this: https://skitch.com/gabor.hojtsy/gb8nd/translate-localization-client-to-h... That page can have some explanation and a pointer to contact team admins if you don't have permission and a button if you do to start over the release? Seems like in-place in the group, much more closer to your workflow and can also be linked from the release list you worked with so far, since the page provides useful information even if you don't have permission to actually do something there. Also fits the permission/group model better.

Looks like a good direction. (I think you can still keep the missing strings links in the release table too?)

Well, right, ok, let's skip that then.

#27: I tested the patch and works well.

Thanks! Committed and pushed. Should deploy soon later today.

Needs to be ported to D7.

This should be deployed now, but it does not work. Using the project title instead of the short name and then pretending it is the short name does not really work. Also, it is displayed at a very odd place. I've suggested it would display under the release dropdown, right? Why are my suggestions ignored?

BTW I've rolled back all patches committed from here, so you can start from a clean slate and broken functionality is not exposed on localize.drupal.org.

Thanks, committed and pushed, should be forward ported to Drupal 7 too.

Ok, rolled out on localize.drupal.org too. Community managers have the start over permission enabled. Hope this works good now. Still to be ported.

probably we have to add permission for a group of users for l.d.o with Start Over permission, not only admins

Re-rolled for Drupal 7

Committed