1. A detailed description of what your project does, including how it is different from other, similar projects, if applicable.
Views Custom Style is targetted at themers. It allows you to limit the amount of custom template files for your Displays. It also adds more flexibility as all resulting rows and fields can be printed within one template file. Only 2 templates remain, the wrapper (views-view.tpl.php) and the custom style wrapper (views-view-custom.tpl.php).

In short, this module is meant to speed up the theming process and add a bit more flexibility for theming the output of the Views results.

2. For themes it's helpful to include a screenshot.
N/A

3. A link to your project page.
http://drupal.org/sandbox/thomastorfs/1267470

4. A direct link to your git repository (git clone ...).
git clone http://git.drupal.org/sandbox/thomastorfs/1267470.git views_custom_style

5. Please specify if it's for Drupal 6 and/or 7.
Drupal 7, however Drupal 6 will be available as well in the future

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* Git release branch missing, see http://drupal.org/node/1015226
* Remove LICENSE.txt, it is added by drupal.org packaging automatically
* info file: only list files there that contain classes or interfaces
* "Implementation of hook_views_api()." this should be "Implements hook_views_api().", see http://drupal.org/node/1354#hookimpl
* template_preprocess_views_view_custom(): indentation should be just 2 spaces at all levels
* "//dsm($vars);" Remove debug statements from your code.
* views_customstyle_views_plugins(): indentation error in one sub array
* Indentation errors in other places also.

Anonymous’s picture

Anonymous (not verified) commented

Hi klausi, thanks for taking the time to review the module. I'll update the code as soon as possible.

misc’s picture

misc commented

@thomastorfs has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Anonymous’s picture

Anonymous (not verified) commented

Hi MiSc,

This project is not abandoned. We've been incredibly busy and have not found the time to finalize this module. The module will be updated once this hectic period is over.

-Thomas

misc’s picture

misc commented

Great. Should we mark this as postponed until you got the time to work on the module?

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Postponed

That's a good idea. It may take a couple weeks before we have more time. I updated it to postponed.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Postponed » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Anonymous’s picture

Anonymous (not verified) commented
Status: Closed (won't fix) » Needs work

Hi klausi, thanks for the update. We're using this module every day at the office, yet I haven't found the time to alter the code to fit the Drupal standards. It does however work very well in our development environment. I'll keep you updated.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Anonymous’s picture

Anonymous (not verified) commented
Status: Closed (won't fix) » Needs review

Hi klausi, I committed our latest changes and applied your feedback.

Can you check the current version?

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

monymirza’s picture

monymirza
Primary language Urdu
Location Islamabad
commented
Status: Needs review » Needs work

Hi,

Some issues need to fix, see here:
http://ventral.org/pareview/httpgitdrupalorgsandboxthomastorfs1267470git

Anonymous’s picture

Anonymous (not verified) commented

Hi monymirza,

Thanks for your feedback. It's a bit odd, since I reviewed the code with Drupal Coder before submitting, and it passed.

I'll have another look.

Anonymous’s picture

Anonymous (not verified) commented

Apparently there's a difference between Drupal Coder and ventral.org. The checks that ventral applies are much more strict, even when Drupal Coder is set to show all minor issues. For instance, classes within views are not uppercase or lowercamel. I wonder why the inconsistency.

Example (from views_handler_area.inc):

class views_handler_area extends views_handler {

Does my code need to apply different rules?

Anonymous’s picture

Anonymous (not verified) commented

Can anyone have a new look please? I updated the code according to the feedback.

Thanks

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Needs work

Quick review based on http://ventral.org/pareview/httpgitdrupalorgsandboxthomastorfs1267470git:

Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Package
There is no need to define an own package in your .info-file unless you plan to create a family of modules with the same purpose. The default package ("Other") would fit as well (simple remove the line).
files[] without classes or interfaces
* line 10 in views_customstyle.info: views_customstyle.views.inc
This lines should be removed. It's only necessary to declare files[] if they declare a class or interface.

Please note: The Coder module currently has an unresolved flaw which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do not contain classes or interfaces.

You can ignore the errors listed by http://ventral.org/pareview/httpgitdrupalorgsandboxthomastorfs1267470git regarding views_customstyle_style_plugin.inc since fixing these errors would require the views module to change its standards (which will not happen ;) ).

Anonymous’s picture

Anonymous (not verified) commented

Hi stBorchert,

Thanks for your feedback. I'll remove the package details and alter the views integration. Regarding the master branch, that should be fixed already. I am working on the 7.x-1.x branch since last commit.

cheers!

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.