Closed (fixed)
Project:
Location Map
Version:
7.x-2.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 Sep 2011 at 10:04 UTC
Updated:
24 May 2014 at 13:51 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
babbage commentedThis is not a current feature of the module though it would be a good thing to be implemented in the future. Patches are of course welcome and will make it happen sooner.
If you need this functionality now, see the GMap module.
Comment #2
elvin - albania drupal developerThanks a lot babbage.
I have actually started using Gmap for a project i am currently building. But i needed to display only 1 gmap on a block for a small brochure site, and i didnt want to use gmap only for that.
Anyways thanks a lot
Elvin Xhimitiku
Drupal in Albania
Comment #3
babbage commentedI totally agree that this is how Location Map should work, and you should not need GMap for something that simple. I'm just grossly over-committed so can't do the work anytime soon. :|
Comment #4
elvin - albania drupal developerDont worry man, it can wait :D
work comes first.
Best
Comment #5
Anonymous (not verified) commentedI'm confused...
This issue seems to indicate that you can't display a map in a block, and yet the project page says "Location Map will...create a block with a static image of the centre of your map, which links to the larger map."
Is it possible to display a map in a block or not?
Comment #6
vicksvaporub commentedThe module creates a block with a static version of the map, just like a thumbnail.
I have another newbbie question ... can I add the map to a Panel?
Comment #7
Anonymous (not verified) commentedAh, ok. Changing the title to prevent further confusion then.
Comment #8
Anonymous (not verified) commentedTurns out I needed this functionality too. I therefore made the attached patch which allows you to select whether the LocationMap block will display a static image or an interactive map.
Let me know how this works for you.
Comment #9
vicksvaporub commentedmmm... not working. I'm not sure if we are using the same LocationMap Module version, though.
I will check the patch again, maybe I have missed something while copying & pasting.
Comment #10
Anonymous (not verified) commentedThe patch was made against the 7.x-1.x branch of Git...
Comment #11
vicksvaporub commentedIt's not working. Probably my fault (not very experienced in php programming) The map won't show (it works only if I choose the static version)
I attached my locationmap.module. I think I made all the changes needed, but may be missing something.
Comment #12
dropbydrop commented+1
please commit. thanks
Comment #13
sinini commentedthere's an empty div being generated, but nothing is loaded into it... there might be only a small part missing from your original code? would be nice if you can have a look again...
Comment #14
sinini commentedok i've got it:
just a fast try to get it working, (using API2):
in line 441 instead of:
just put
Comment #15
LeisureLarry commentedThanks BWPanda. I've uploaded a patched version 1.1 to my git account:
https://github.com/LeisureLarry/Drupal7-Modules-Locationmap
It supports both API version 3 (just don't enter a key) and interactive blocks.
Comment #16
idflood commentedI tried to apply the patch posted in #8 and it applies perfectly on the 7.x-2.x branch. It had a little warning about file permission, so maybe this should be changed before merging:
I'm using the block with panels and so far no issue found. Thanks @BWPanda!
Comment #17
rupertj commentedThanks BWPanda - I've committed this to the 2.x branch. It'll show up in 7.x-2.2 when it's released.
Comment #18
plamenut commentedPatch from #8 works against 7.x-2.1.
However, after patching it starts to trow an error :
Notice: Undefined variable: type in locationmap_block_image() (line 437 of /home/alphatan/public_html/elmagnifico/sites/all/modules/locationmap/locationmap.module).
the variable:
$type == 'interactive'
Caches cleared and update was run. Didn't try an uninstall/reinstall tough.
Thank everyone, BWPanda, especially.
Comment #19
rupertj commentedplamenut - Could you give the code from git a try? I just had a look there (where that patch is merged) and can't see how $type could end up undeclared.
If that works for you, I'll roll a 2.2 release.
Comment #20
cweagansI would also like to see an option presented for interactive/static image when the block is used in panels pages. If it would be accepted, I can open a separate issue and code it up.NEVERMIND. I guess you can just configure the block from the panels page =P
Comment #21
rupertj commentedNo reply, and the code is working for others, so closing this issue.