User signature does not appear in comment preview

OK, here is patch.

Attached and produced what is below. If anything is odd, let me know so I can correct.

---
 core/modules/comment/comment.module |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/core/modules/comment/comment.module b/core/modules/comment/comment.module
index 7ad14e8..64d74ce 100644
--- a/core/modules/comment/comment.module
+++ b/core/modules/comment/comment.module
@@ -1896,6 +1896,8 @@ function comment_preview($comment) {
     if (!empty($account->uid)) {
       $comment->uid = $account->uid;
       $comment->name = check_plain($account->name);
+      $comment->signature = $account->signature;
+      $comment->signature_format = isset($comment->signature_format) ? $comment->signature_format : NULL;
     }
     elseif (empty($comment->name)) {
       $comment->name = variable_get('anonymous', t('Anonymous'));
-- 
1.7.4.1

+++ b/core/modules/comment/comment.testundefined
@@ -866,8 +866,14 @@ class CommentPreviewTest extends CommentHelperCase {
+    $edit['signature[value]'] = '<a href="http://example.com/">Test signature</a>';

This is a fairly minor point, but we usually use $this->randomName(8) for text like this and then we test for that random string later. This garuntees that we dont find the string "Test Signature" somewhere else on the page for some (unlikely) reason.

Just make sure you set a variable with the random string so you have something to assert later....

-22 days to next Drupal core point release.

Niklas,

Thank you. Yep, you make a good point. Want to get back to this when I have a sec.

Niklas, Cool, way to go!

Patch applies & tests OK.

-Darrell

Tested this, I needed to change the status to "reviewed & tested by the community."

Makes sense. Committed/pushed to 8.x, moving to 7.x for backport.

Tested 7.x backport. Patch applied and working.

darrellulm

Hm. I guess there's a small chance this could break themes that aren't expecting it, but OTOH this feels like a straight-up bug fix.

Committed and pushed to 7.x. Thanks!

Cool. Thanks for the assist @Niklas Fiekas + 1