Diving into the node.tpl (using alpha starterkit) I noticed comment links are hidden to be rendered later 

      // We hide the comments and links now so that we can render them later.
      hide($content['comments']);
      hide($content['links']);
      print render($content);
    ?>
  </div>
  
  <div class="clearfix">
    <?php if (!empty($content['links'])): ?>
      <div class="links node-links clearfix"><?php print render($content['links']); ?></div>
    <?php endif; ?>

    <?php print render($content['comments']); ?>
  </div>
</div>

As a result the comment links are removed, but not the ul li classes. Which affects the layout See screenshot

CommentFileSizeAuthor
#8 content-links.patch760 bytespixelsweatshop
Picture 6.png435.75 KBpixelsweatshop

Comments

witchcraft’s picture

witchcraft commented

Since omega no longer in rc5 try to upgrade to latest version
tell us if issue fixed.
if so please close it.

witchcraft’s picture

witchcraft commented
Status: Active » Postponed
pixelsweatshop’s picture

pixelsweatshop commented
Version: 7.x-3.0-rc5 » 7.x-3.0

Still an issue in 3.0

pixelsweatshop’s picture

pixelsweatshop commented
Status: Postponed » Active
finex’s picture

finex commented

Cannot reproduce on a new HTML5 Omega 7.x-3.0 subtheme. Very strange.

pixelsweatshop’s picture

pixelsweatshop commented

its using the xhtml starterkit

pixelsweatshop’s picture

pixelsweatshop commented
Status: Active » Needs review
StatusFileSize
new content-links.patch760 bytes

Ok. I finally had time to source the issue. It's just some css in omega-visuals.css

The links are using a float:left instead of a display:inline

See attached patch that fixes it up (changing to inline also required some padding and margin adjustments to accommodate)...

Old CSS

.node-links ul li a,
.comment-links ul li a {
  text-transform: lowercase;
  display: block;
  float: left;
  text-decoration: none;
  -moz-background-clip: padding;
  -webkit-background-clip: padding;
  background-clip: padding-box;
  margin: 0 0.5em 0.5em 0;
  vertical-align: middle;
  -webkit-appearance: none;
  -moz-border-radius: 11px;
  -webkit-border-radius: 11px;
  border-radius: 11px;
  background: #ddd url(../images/button.png) repeat-x;
  background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fff), color-stop(1, #ddd));
  background: -moz-linear-gradient(top center, #fff 0%, #ddd 100%);
  border: 1px solid;
  border-color: #ddd #bbb #999;
  cursor: pointer;
  color: #333;
  font: bold 12px/1.2 Arial, sans-serif;
  outline: 0;
  overflow: visible;
  padding: 4px 10px 3px;
  text-shadow: #fff 0 1px 1px;
  width: auto;

  /* IE7 */
  *padding-top: 2px;
  *padding-bottom: 0px;
}

.node-links ul li a:hover,
.comment-links ul li a:hover {
  background: #FFF;
}

Change to:

.node-links ul li a,
.comment-links ul li a {
  text-transform: lowercase;
  text-decoration: none;
  -moz-background-clip: padding;
  -webkit-background-clip: padding;
  background-clip: padding-box;
  margin: 0;
  vertical-align: middle;
  -webkit-appearance: none;
  -moz-border-radius: 11px;
  -webkit-border-radius: 11px;
  border-radius: 11px;
  background: #ddd url(../images/button.png) repeat-x;
  background: -webkit-gradient(linear, left top, left bottom, color-stop(0, #fff), color-stop(1, #ddd));
  background: -moz-linear-gradient(top center, #fff 0%, #ddd 100%);
  border: 1px solid;
  border-color: #ddd #bbb #999;
  cursor: pointer;
  color: #333;
  font: bold 12px/1.2 Arial, sans-serif;
  outline: 0;
  overflow: visible;
  padding: 4px 10px 3px;
  text-shadow: #fff 0 1px 1px;
  width: auto;

  /* IE7 */
  *padding-top: 2px;
  *padding-bottom: 0px;
}

.node-links ul li a:hover,
.comment-links ul li a:hover {
  background: #FFF;
}

.node-links .inline li,
.comment-links .inline li{
	margin-right:0.2em;
}
cellar door’s picture

cellar door commented
Assigned: Unassigned » himerus
Status: Needs review » Postponed

This should be postponed as making the change could potentially break sites that have currently styled around it.

himerus’s picture

himerus commented
Status: Postponed » Needs work

This was indeed a poor implementation of node links, and fixes for this issue (and other related) will be addressed in 3.2 in a manner that will not break/alter current sites, but apply to new starterkit implementations.

marcoka’s picture

marcoka commented
Title: Hiden Comments links are still rendered » Hidden Comments links are still rendered
himerus’s picture

himerus commented
Title: Hidden Comments links are still rendered » Node and Comment links should be displayed inline rather than floated

In fact, this title is wildly misleading, the links ARE being printed out, and evident in the screenshot in the original post, there should be 3 list items, and they are there.

the spacing you are seeing in that screenshot is odd, but not normal for any default installs I've done.

The title is updated to a more reasonable explanation of the issue here, and it will be addressed in 3.2, but ONLY for newly generated subthemes. If a fix for this is needed in a current project prior to Omega 3.2, then proper CSS (as is also demonstrated above) should be used to overwrite the positioning of the links should it give someone problems.

himerus’s picture

himerus commented

will be fixed in 3.2

steinmb’s picture

steinmb commented
Version: 7.x-3.0 » 7.x-3.x-dev
Assigned: himerus » Unassigned
Issue summary: View changes