(Attached image, see #comment 1)

CommentFileSizeAuthor
#17 views_display_header_fix-1268466-2.patch5.99 KBjessebeach
#9 css.patch2.87 KBdroplet
#5 clear_float.patch605 bytesdroplet
#1 display-top.jpg45.5 KBdroplet
0001-Fix-views-display-style-error.patch905 bytesdroplet

Comments

droplet’s picture

droplet commented
StatusFileSize
new display-top.jpg45.5 KB
droplet’s picture

droplet commented

Updated issue summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Never saw this, on which theme does this happen?

+++ b/includes/admin.incundefined
@@ -1192,7 +1192,7 @@ function views_ui_preview_form($form, &$form_state, $view, $display_id = 'defaul
+  $element['#attributes']['class'] = array('views-display-top clearfix');

Class is an array here, so there is no need to use a single string.

merlinofchaos’s picture

merlinofchaos commented

I'm with dereine, I've never ever seen this happen.

droplet’s picture

droplet commented
Status: Needs review » Needs work

ahh right, that's an array.

D7.x-dev-today (GIT)
Views 7.x-3.x (GIT)
IE9, Chrome 15, FF 6 all have this problem.

** another interesting things, it enabled all default views after installation, new changes ??

droplet’s picture

droplet commented
Status: Needs work » Needs review
StatusFileSize
new clear_float.patch605 bytes

damn, always forgot to attach files.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs work » Needs review

So like dereine asked, what theme is this being displayed in? Or is it custom?

dawehner’s picture

dawehner
Primary language German
commented

Just from looking at it, it seems to be seven.

In general this issue does exist on other themes, so if this fixes mutliple themes at the same time it might make sense.

merlinofchaos’s picture

merlinofchaos commented

Maybe, but I can't help but think that themes that just float all submits are going to have other problems. I guess it's not a dangerous fix...it just concerns me a bit.

droplet’s picture

droplet commented
StatusFileSize
new css.patch2.87 KB

First time look into views admin css. Seems like a lot of code that can be improve. can you point me to any exist issue about CSS clean up or I will create a one new.

bartik, seven, stark looks okay.

merlinofchaos’s picture

merlinofchaos commented

That is a lot of CSS changes with no explanation that could have potential effects. Would need jbeach to look that over.

aem34’s picture

aem34 commented

had this issue too, applied the patch (0001-Fix-views-display-style-error.patch), everything back ok

when it happened for me :
drupal 7.7, views rc1, upgrade to drupal 7.8

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

Okay, please remove the random CSS fixes. I don't know what they do and I don't want to evaluate a whole bunch of CSS fixes. There's one issue here.

It turns out that in a very recent commit, in Seven ul.secondary was changed from 'text-align: right' to 'float: right' and we're using the class 'secondary' on those tabs. This is causing a conflict. Suddenly they are floating when they didn't used to.

They shouldn't be floating. I don't think the fix is a clearfix (that IS a fix, just not the best fix).

droplet’s picture

droplet commented 
+++ b/css/views-admin-rtl.cssundefined
@@ -25,10 +25,6 @@
-.views-displays {
-  float: right;
-}

+++ b/css/views-admin.cssundefined
@@ -109,7 +109,6 @@
-  float:left; /* LTR */

Don't see any reason why it needs floating on .views-displays

+++ b/css/views-admin.cssundefined
@@ -314,31 +312,7 @@ div.form-item-options-value-all {
-/* @group Clearfix
- *
- * @see http://perishablepress.com/press/2009/12/06/new-clearfix-hack
- */
 
- /* Reset the formatting context for all modern browsers */
-.views-display-tab .fieldset-wrapper:after,
-ul.secondary:after {
-  clear: both;
-  content: " x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x ";
-  display: block;
-  font-size: xx-large;
-  height: 0 !important;
-  line-height: 0;
-  overflow: hidden;
-  visibility: hidden;
-}
-
-/* Reset the formatting context for IE */
-.views-display-tab .fieldset-wrapper,
-ul.secondary {
-  zoom: 1;
-}
-
-/* @end */

It's not a standard clearfix of the ref URL.

Which a lot of XXXXX is trying to put the content WIDTH to 100% of page.

(remove this & above floating on .view-displays will be same results)

(and replace this code with add a .clearfix on ul.secondary.)

adding styles to ul.secondary without qualified a .views-xxx class is not a good pattern)

+++ b/css/views-admin.seven.cssundefined
@@ -192,7 +192,7 @@ fieldset.fieldset-no-legend {
-  margin-right: 18em;
+  float: left

It's wrong patch (margin-right is duplicated with code on same file)

+++ b/css/views-admin.theme.cssundefined
@@ -24,8 +24,7 @@
-  margin-left: 12px;
-  margin-right: 12px;
+  margin: 12px 12px 0 12px;

@@ -413,7 +412,6 @@ td.group-title {
-  margin-bottom: 14px;

No comments. Good practice only.

It should be margin: 14px 12px 0 12px.

+++ b/includes/admin.incundefined
@@ -1192,7 +1192,7 @@ function views_ui_preview_form($form, &$form_state, $view, $display_id = 'defaul
+  $element['#attributes']['class'] = array('views-display-top', 'clearfix');

no needs now.

Willing to make a new patch if you love the clean up & fixes. (Actually, it's not the cleanup. It's all the fixes. No visual problem not equal to no problem)

Vlad Stratulat’s picture

Vlad Stratulat commented

Here's what you have to do to fix this error.

views-admin.seven.css - line 193

.views-display-top ul.secondary {
    background-color: transparent;
++  float: none;
    margin-right: 18em;
}

views-admin.theme.css - line 475

.views-displays .secondary .action-list  li {
    background-color: #f1f1f1;
    border-color: #cbcbcb;
    border-style: solid;
    border-width: 0 1px;
++  float: none;
++  margin: 0;
    padding: 2px 9px;
}

These changes will fix this errors http://drupal.org/files/issues/Clipboard02_25.jpg

droplet’s picture

droplet commented

sure if you don't want to get rid of dummy code there.

only float: none; on viewms-admin.theme is okay.

Vlad Stratulat’s picture

Vlad Stratulat commented

It's okay only to fix tabs wrapper. But take a look to my screenshot in my previous post. Pay attention to "+Add" tab drop-down list.

jessebeach’s picture

jessebeach commented
StatusFileSize
new views_display_header_fix-1268466-2.patch5.99 KB

droplet, I agree with cleaning out the crufty CSS clearfix. If it had a purpose, it's lost to me now. The standard clearfix class is the best approach. I added some extra code to the RTL files in Bartik and Garland to account for changes.

droplet’s picture

droplet commented
Status: Needs work » Reviewed & tested by the community

1. Frontend: Garland, Bartik, Seven, no errors.
2. Code looks okay

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

It's great that you united here to great an improvement.

Commited to 7.x-3.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.