Closed (fixed)
Project:
Notifications
Version:
7.x-1.x-dev
Component:
Content subscriptions
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Sep 2011 at 02:39 UTC
Updated:
4 Sep 2015 at 18:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berekel commentedComment #2
vrc3 commentedYes, I am experiencing this bug as well.
Comment #3
jide commentedSame here, using the latest dev version.
Comment #4
jide commentedLooking at the code, class Notifications_User_Content_Subscription extends Notifications_Content_Subscription. Moreover hook_notifications() in notifications_user.module skips things like 'event types', 'object types', 'message templates', 'event classes'... and does not implements hook_action_info() etc.
I guess notifications_content should somehow trigger things for notifications_user, but I have no clues how this should be done... If anyone has some tips, I should be able to do the code.
Comment #5
kerrymick commentedI also have this issue with my site. Has anyone been able to figure this problem out? Any help is hugely appreciated.
Comment #6
amarnus commentedHave attached a patch and a test file along with it. If you still have a need for this feature, do help me test it.
Comment #7
czigor commentedJust what I was needing today! However, I cannot apply the patch.
Is this against the latest dev? Also, I think patches should be relative to the module dir.
Comment #8
amarnus commentedMy bad, @czigor. Re-rolled patch. Now against latest 7.x-1.x-dev.
Comment #9
czigor commentedApplying the patch I get a
So I need to patch notifications_user/notifications_user.info manually. The reason of the failure is that my info file does not end after files[]. Have you downloaded the dev from http://ftp.drupal.org/files/projects/notifications-7.x-1.x-dev.tar.gz?
After this, however, the patch works great, thanks! I will test it further.
Comment #10
amarnus commentedFinal (hopefully) re-roll.
Didn't know that the info added by the Drupal package script is not tracked in the git repo. My earlier patch would work against the head of the 7.x-1.x branch.
Comment #11
amarnus commentedComment #12
sheise commented#10 seems to do the trick for me. Thanks!
Comment #13
amarnus commentedComment #14
sajosh commentedIn case there's still hesitation by this wonderful modules owner about patch #10, I'm posting my results here.
In short, the patch works.
Longer version. I started a fresh install of drupal 7.21 and just sandboxed some ideas for a while. I landed on a OG, Notifications 7.x-1.0-alpha2 and Messaging 7.x-1.0-alpha2 solution. But for some reason the notifications just seemed so so buggy. Notifications by author weren't working for non-admin users. I tried many many combinations.
Finally, I deleted the installation and DB and started over again. This time with a intent focus on get notifications to work in OG. I installed D 7.22 and Notifications 7.x-1.x-dev and Messaging 7.x-1.x-dev. I still couldn't get notifications by author to work.
Luckily I found this post and patch. Installed the patch and it all now works.
I've tested several combinations first without OG then with OG and it all works.
Comment #15
xeniak commentedThe problem I see with this solution is that it adds another field instead of using the existing Notifications_User_Field, with the unfortunate side effect of breaking the field autocomplete on the subscription form. Instead, I added the following code to notifications_user.module:
Comment #16
damienmckennaComment #19
Nafes commentedCleared some trailing whitespaces and committed. Thanks amarnus!