ffmpeg_converter is adding a padding by default, but it shouldn't, because mostly you don't need that padding. Most web players are able to add that padding. So i want to turn off this feature. The settings for that have to go into the ffmpeg_wrapper settings form, I guess.

See also #1269322: Disable padding by default. for the required changes to ffmpeg_converter.

CommentFileSizeAuthor
#1 ffmpeg_wrapper-padding-1269310-1.patch3 KBosopolar

Comments

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
StatusFileSize
new ffmpeg_wrapper-padding-1269310-1.patch3 KB
osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Status: Active » Needs review
zoo33’s picture

zoo33 commented

I'm generally in favor of the idea, but haven't tested either if the patch itself is working or how well players handle varying formats. That can of course be left up to the site admin to decide, but I guess the default behavior should be the one that works best in most cases.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented

That's right therefore the default is with padding enabled - this is also for compatibility reasons to not break current behavior. The form default is set like this:

'#default_value' => isset($configuration['ffmpeg_video_size_add_padding']) ? $configuration['ffmpeg_video_size_add_padding'] : 1,
osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Issue summary: View changes

link issue 1269322